Skip to content

Issue #13321: Kill mutation for SuppressWarningHolderCheck-1#13377

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:swc1
Jul 10, 2023
Merged

Issue #13321: Kill mutation for SuppressWarningHolderCheck-1#13377
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:swc1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 7, 2023 •
edited
Loading

Issue #13321: Kill mutation for SuppressWarningHolderCheck-1

Check :-

https://checkstyle.org/checks/annotation/suppresswarningsholder.html#SuppressWarningsHolder

Mutation

checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml

Lines 93 to 127 in 0169b08

<mutation unstable="false">
<sourceFile>SuppressWarningsHolder.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder</mutatedClass>
<mutatedMethod>findAllExpressionsInChildren</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling</description>
<lineContent>childAST = childAST.getNextSibling();</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SuppressWarningsHolder.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder</mutatedClass>
<mutatedMethod>getStringExpr</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getLastChild with receiver</description>
<lineContent>expr = firstChild.getLastChild().getText();</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SuppressWarningsHolder.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder</mutatedClass>
<mutatedMethod>getStringExpr</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_0</mutator>
<description>RemoveSwitch 0 (case value 58)</description>
<lineContent>switch (firstChild.getType()) {</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SuppressWarningsHolder.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder</mutatedClass>
<mutatedMethod>getStringExpr</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_1</mutator>
<description>RemoveSwitch 1 (case value 59)</description>
<lineContent>switch (firstChild.getType()) {</lineContent>
</mutation>

Explaination

Test added

@Kevin222004 Kevin222004 force-pushed the swc1 branch 5 times, most recently from 08251b5 to b7c8333 Compare July 7, 2023 19:21
@Kevin222004 Kevin222004 mentioned this pull request Jul 7, 2023
Closed
41 tasks
romani
romani requested changes Jul 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@Kevin222004 Kevin222004 force-pushed the swc1 branch 3 times, most recently from d147ca9 to fff0f64 Compare July 10, 2023 17:25
romani
romani approved these changes Jul 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge .

I will merge after CI passed

@romani romani merged commit ea75907 into checkstyle:master Jul 10, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani