Issue #13321: Kill mutation for OrderedPropertiesCheck-2 by Kevin222004 · Pull Request #13374 · checkstyle/checkstyle

Kevin222004 · 2023-07-07T07:41:52Z

Issue #13321: Kill mutation for OrderedPropertiesCheck-2

Check :-

https://checkstyle.org/checks/misc/orderedproperties.html#OrderedProperties

Mutation :-

checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml

Lines 39 to 55 in 20a52f7

    
           <mutation unstable="false"> 
        
             <sourceFile>OrderedPropertiesCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck</mutatedClass> 
        
             <mutatedMethod>getKeyPattern</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/util/regex/Matcher::quoteReplacement</description> 
        
             <lineContent>.replaceAll(Matcher.quoteReplacement(&quot;\\\\ &quot;)) + &quot;[\\s:=].*&quot;;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>OrderedPropertiesCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck</mutatedClass> 
        
             <mutatedMethod>getKeyPattern</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to java/util/regex/Matcher::quoteReplacement with argument</description> 
        
             <lineContent>.replaceAll(Matcher.quoteReplacement(&quot;\\\\ &quot;)) + &quot;[\\s:=].*&quot;;</lineContent> 
        
           </mutation>

Explaination

Test added

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/c3213434af8523d918594b88ce5554f7/raw/3565cfcd975e228af515bb34ce22c83afce0a7c7/opc.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

Kevin222004 · 2023-07-07T07:42:25Z

GIthub, generate report

github-actions · 2023-07-07T08:29:53Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/389687d_2023082858/reports/diff/index.html

Kevin222004 · 2023-07-07T19:42:48Z

Github, generate report

github-actions · 2023-07-07T20:14:27Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/389687d_2023201355/reports/diff/index.html

Vyom-Yadav · 2023-07-16T10:04:17Z

@Kevin222004 No rationale?

Vyom-Yadav

Items:

Vyom-Yadav · 2023-07-16T10:32:00Z

src/main/java/com/puppycrawl/tools/checkstyle/checks/OrderedPropertiesCheck.java

    private static Pattern getKeyPattern(String keyName) {
        final String keyPatternString = "^" + SPACE_PATTERN.matcher(keyName)
-                .replaceAll(Matcher.quoteReplacement("\\\\ ")) + "[\\s:=].*";
+                .replaceAll("") + "[\\s:=].*";


@Kevin222004 You can have properties with space in them, eg:

foo\ bar:hoo

The whitespace is escaped. You can see https://stackoverflow.com/q/2108103/15412365

@Kevin222004 SPACE_PATTERN.matcher(keyName).replaceAll(Matcher.quoteReplacement("\\\\ ")), whitespace is being quoted to get the key pattern. Whitespace is escaped using \ in key so double quoting is required to get the pattern.

Please add print statements to see the difference between patterns, which will highlight what is needed to be changed. Please do ask if something is unclear.

Thanks @Vyom-Yadav for your help.

Kevin222004 · 2023-08-08T16:25:05Z

Test added

Kevin222004 · 2023-08-08T18:14:04Z

@romani please re-run failing ci

romani · 2023-08-08T21:48:52Z

Circleci was relaunched

Vyom-Yadav

LGTM!

romani

Ok to merge

Covered by new test

Kevin222004 mentioned this pull request Jul 7, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

Kevin222004 marked this pull request as ready for review July 7, 2023 19:40

romani requested review from Vyom-Yadav, rdiachenko and romani July 9, 2023 14:39

romani assigned Vyom-Yadav Jul 9, 2023

Vyom-Yadav suggested changes Jul 16, 2023

View reviewed changes

This was referenced Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

Resolve pitest survivals in modules - 3 #13501

Closed

Issue checkstyle#13321: Kill mutation for OrderedPropertiesCheck-2

b01e2ee

Kevin222004 force-pushed the opc2 branch from 389687d to b01e2ee Compare August 8, 2023 16:23

Vyom-Yadav approved these changes Aug 9, 2023

View reviewed changes

Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Aug 9, 2023

romani approved these changes Aug 9, 2023

View reviewed changes

romani merged commit b57a0f8 into checkstyle:master Aug 9, 2023

	<mutation unstable="false">
	<sourceFile>OrderedPropertiesCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck</mutatedClass>
	<mutatedMethod>getKeyPattern</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/util/regex/Matcher::quoteReplacement</description>
	<lineContent>.replaceAll(Matcher.quoteReplacement("\\\\ ")) + "[\\s:=].*";</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>OrderedPropertiesCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck</mutatedClass>
	<mutatedMethod>getKeyPattern</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to java/util/regex/Matcher::quoteReplacement with argument</description>
	<lineContent>.replaceAll(Matcher.quoteReplacement("\\\\ ")) + "[\\s:=].*";</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check :-

Mutation :-

Explaination

Uh oh!

Kevin222004 commented Jul 7, 2023

Uh oh!

github-actions bot commented Jul 7, 2023

Uh oh!

Kevin222004 commented Jul 7, 2023

Uh oh!

github-actions bot commented Jul 7, 2023

Uh oh!

Vyom-Yadav commented Jul 16, 2023

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav Jul 16, 2023

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

Kevin222004 Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Aug 8, 2023

Uh oh!

Kevin222004 commented Aug 8, 2023

Uh oh!

romani commented Aug 8, 2023

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jul 7, 2023 •

edited

Loading