Skip to content

Issue #13321: Kill mutation for OrderedPropertiesCheck-1#13373

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:opc1
Jul 19, 2023
Merged

Issue #13321: Kill mutation for OrderedPropertiesCheck-1#13373
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:opc1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 7, 2023 •
edited
Loading

Issue #13321: Kill mutation for OrderedPropertiesCheck-1

Check :-

https://checkstyle.org/checks/misc/orderedproperties.html#OrderedProperties

Mutation :-

checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml

Lines 57 to 82 in 20a52f7

<mutation unstable="false">
<sourceFile>OrderedPropertiesCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck$SequencedProperties</mutatedClass>
<mutatedMethod>put</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Properties::put</description>
<lineContent>return super.put(key, value);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>OrderedPropertiesCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck$SequencedProperties</mutatedClass>
<mutatedMethod>put</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Properties::put with argument</description>
<lineContent>return super.put(key, value);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>OrderedPropertiesCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck$SequencedProperties</mutatedClass>
<mutatedMethod>put</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.returns.NullReturnValsMutator</mutator>
<description>replaced return value with null for com/puppycrawl/tools/checkstyle/checks/OrderedPropertiesCheck$SequencedProperties::put</description>
<lineContent>return super.put(key, value);</lineContent>
</mutation>

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/c3213434af8523d918594b88ce5554f7/raw/3565cfcd975e228af515bb34ce22c83afce0a7c7/opc.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 7, 2023

Github, generate report

@Kevin222004 Kevin222004 mentioned this pull request Jul 7, 2023
Closed
41 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cbbd3ed_2023073819/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review July 7, 2023 19:40
@romani
Copy link
Copy Markdown
Member

romani commented Jul 8, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1d96a21_2023201951/reports/diff/index.html

romani
romani approved these changes Jul 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.
Weird code but we definitely not use Properties type fully.

@romani romani requested review from Vyom-Yadav and rdiachenko July 9, 2023 13:11
Vyom-Yadav
Vyom-Yadav approved these changes Jul 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Jul 16, 2023
rdiachenko
rdiachenko approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko
Copy link
Copy Markdown
Member

rdiachenko commented Jul 18, 2023

Rebased

@romani romani merged commit 8b7dac5 into checkstyle:master Jul 19, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav