Skip to content

Issue #13321: Kill mutation for OuterTypeFile-2#13370

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:out2
Jul 7, 2023
Merged

Issue #13321: Kill mutation for OuterTypeFile-2#13370
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:out2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 6, 2023 •
edited
Loading

Issue #13321: Kill mutation for OuterTypeFile-2

Check :-

https://checkstyle.org/checks/misc/outertypefilename.html#OuterTypeFilename

Mutation

checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml

Lines 84 to 109 in 20a52f7

<mutation unstable="false">
<sourceFile>OuterTypeFilenameCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OuterTypeFilenameCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable hasPublic</description>
<lineContent>hasPublic = false;</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>OuterTypeFilenameCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OuterTypeFilenameCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable seenFirstToken</description>
<lineContent>seenFirstToken = false;</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>OuterTypeFilenameCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.OuterTypeFilenameCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable wrongType</description>
<lineContent>wrongType = null;</lineContent>
</mutation>

Explaination

Test added

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/19becb64b46958e038d7cc25e7ee2653/raw/8a01e220b6dda4d1bca26cb1916437d230ab8fa4/out.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 6, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 6, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1195cfa_2023193517/reports/diff/index.html

@Kevin222004 Kevin222004 mentioned this pull request Jul 7, 2023
Closed
41 tasks
@Kevin222004 Kevin222004 marked this pull request as ready for review July 7, 2023 04:23
romani
romani approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 0169b08 into checkstyle:master Jul 7, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani