Issue #13321: Kill mutation for TODOCommentCheck-1#13367
Merged
romani merged 1 commit intocheckstyle:masterfrom Jul 10, 2023
Merged
Issue #13321: Kill mutation for TODOCommentCheck-1#13367romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
41 tasks
Vyom-Yadav
approved these changes
Jul 8, 2023
Member
Vyom-Yadav
left a comment
There was a problem hiding this comment.
LGTM! The best type of mutation PRs!
romani
requested changes
Jul 8, 2023
| public class InputTodoCommentDefault { | ||
| int i; | ||
| public void method() { | ||
| i++; // TODO: do differently in future // violation 'Comment matches to-do format 'TODO:'' |
Member
There was a problem hiding this comment.
As we targeting comment, please move // violation .... on line above or below and skip usage of TODO in message.
We should not mix them and we should see clearly what triggers violation.
Please keep this in mind for all comment and javadoc Checks .
Contributor
Author
There was a problem hiding this comment.
I am not sure why this is happening.
Contributor
Author
There was a problem hiding this comment.
may be
this needs to be TokenTypes.SingleLineComment and TokenTypes.BlockComment
I have worked with comment in fall-thru pr but i never face this in that pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13321: Kill mutation for TODOCommentCheck-1
Check
https://checkstyle.org/checks/misc/todocomment.html#TodoComment
Mutation
checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml
Lines 156 to 172 in 2be5780
Explaination
Test added