Skip to content

Issue #13321: Kill mutation for UncommentedMainCheck-2#13364

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:UMC2
Jul 10, 2023
Merged

Issue #13321: Kill mutation for UncommentedMainCheck-2#13364
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:UMC2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 6, 2023

Issue #13321: Kill mutation for UncommentedMainCheck-2

Check

https://checkstyle.org/checks/misc/uncommentedmain.html

Mutation

checkstyle/config/pitest-suppressions/pitest-misc-suppressions.xml

Lines 210 to 226 in 2be5780

<mutation unstable="false">
<sourceFile>UncommentedMainCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.UncommentedMainCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/FullIdent::createFullIdent</description>
<lineContent>packageName = FullIdent.createFullIdent(null);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>UncommentedMainCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.UncommentedMainCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable packageName</description>
<lineContent>packageName = FullIdent.createFullIdent(null);</lineContent>
</mutation>

Explaination

Test added

@Kevin222004 Kevin222004 mentioned this pull request Jul 6, 2023
Closed
41 tasks
@Kevin222004 Kevin222004 force-pushed the UMC2 branch 2 times, most recently from a980bbd to 2ae8d15 Compare July 6, 2023 08:33
@romani
Copy link
Copy Markdown
Member

romani commented Jul 8, 2023

@Kevin222004 , there is conflict.

If you plan to add test in different PRs please add test methods in different places in file to avoid conflicts.

romani
romani approved these changes Jul 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 10, 2023

Conflict resolved

@romani romani merged commit 872412a into checkstyle:master Jul 10, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani