Issue #13321: Kill mutation for JavadocMethod-10 by Kevin222004 · Pull Request #13356 · checkstyle/checkstyle

Kevin222004 · 2023-07-04T12:31:17Z

Issue #13321: Kill mutation for JavadocMethod-10

Check :-

https://checkstyle.org/checks/javadoc/javadocmethod.html#JavadocMethod

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 93 to 100 in d4b1aec

    
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>beginTree</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable currentClassName</description> 
        
             <lineContent>currentClassName = &quot;&quot;;</lineContent> 
        
           </mutation>

and

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 219 to 334 in d4b1aec

    
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable currentClassName</description> 
        
             <lineContent>currentClassName = currentClassName.substring(0, dotIdx);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator> 
        
             <description>replaced call to java/lang/String::substring with receiver</description> 
        
             <lineContent>currentClassName = currentClassName.substring(0, dotIdx);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/lang/String::lastIndexOf</description> 
        
             <lineContent>final int dotIdx = currentClassName.lastIndexOf(&apos;$&apos;);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getType</description> 
        
             <lineContent>if (ast.getType() == TokenTypes.CLASS_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>if (ast.getType() == TokenTypes.CLASS_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getType</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.ENUM_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.ENUM_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getType</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.INTERFACE_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.INTERFACE_DEF</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getType</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.RECORD_DEF) {</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator> 
        
             <description>removed conditional - replaced equality check with false</description> 
        
             <lineContent>|| ast.getType() == TokenTypes.RECORD_DEF) {</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>processClass</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getText</description> 
        
             <lineContent>String innerClass = ident.getText();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocMethodCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass> 
        
             <mutatedMethod>processClass</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::findFirstToken with receiver</description> 
        
             <lineContent>final DetailAST ident = ast.findFirstToken(TokenTypes.IDENT);</lineContent> 
        
           </mutation>

Explaination

I found this code non used

Regression :-

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/61dfc10_2023134726/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/61dfc10_2023162021/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/df2ff7a8f9969bb2c68d7251a97ffa8b/raw/6a4e81a624fa36483f23b0adcf1fc513ca6df350/JavadocMethod.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

Kevin222004 · 2023-07-04T12:31:36Z

Github, generate report

github-actions · 2023-07-04T13:56:25Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/61dfc10_2023134726/reports/diff/index.html

Kevin222004 · 2023-07-04T14:01:03Z

Github, generate report

github-actions · 2023-07-04T16:21:50Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/61dfc10_2023162021/reports/diff/index.html

romani · 2023-07-30T14:17:58Z

@Kevin222004 , please resovle conflict and prepare PR for review.

Kevin222004 · 2023-07-30T17:11:06Z

#13356 (comment) done ci passed

romani

Ok to merge.
Impressive!

rdiachenko

lgtm

Vyom-Yadav

LGTM!

Kevin222004 marked this pull request as draft July 4, 2023 12:37

Kevin222004 force-pushed the JDM10 branch from 61dfc10 to 9480ae9 Compare July 4, 2023 17:17

Kevin222004 marked this pull request as ready for review July 4, 2023 17:25

Kevin222004 force-pushed the JDM10 branch from 9480ae9 to 969cfc8 Compare July 4, 2023 17:47

Kevin222004 mentioned this pull request Jul 4, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

romani assigned rdiachenko Jul 4, 2023

romani requested review from Vyom-Yadav, rdiachenko and romani July 4, 2023 20:33

Kevin222004 marked this pull request as draft July 6, 2023 09:04

Issue checkstyle#13321: Kill mutation for JavadocMethod-10

09a2a4c

Kevin222004 force-pushed the JDM10 branch from 969cfc8 to 09a2a4c Compare July 30, 2023 16:27

Kevin222004 marked this pull request as ready for review July 30, 2023 16:27

romani approved these changes Jul 31, 2023

View reviewed changes

rdiachenko approved these changes Jul 31, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jul 31, 2023

Vyom-Yadav approved these changes Aug 1, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 1, 2023

This was referenced Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

Resolve pitest survivals in modules - 3 #13501

Closed

romani merged commit addf52c into checkstyle:master Aug 3, 2023

Kevin222004 mentioned this pull request Aug 6, 2023

Issue #13321: Kill mutation for JavadocMethod-1 #13336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13321: Kill mutation for JavadocMethod-10#13356

Issue #13321: Kill mutation for JavadocMethod-10#13356
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JDM10

Kevin222004 commented Jul 4, 2023 •

edited

Loading

Uh oh!

Kevin222004 commented Jul 4, 2023

Uh oh!

github-actions bot commented Jul 4, 2023

Uh oh!

Kevin222004 commented Jul 4, 2023

Uh oh!

github-actions bot commented Jul 4, 2023

Uh oh!

romani commented Jul 30, 2023

Uh oh!

Kevin222004 commented Jul 30, 2023

Uh oh!

romani left a comment

Uh oh!

rdiachenko left a comment

Uh oh!

Vyom-Yadav left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>JavadocMethodCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass>
	<mutatedMethod>beginTree</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable currentClassName</description>
	<lineContent>currentClassName = "";</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check :-

Mutation

Explaination

Regression :-

Uh oh!

Kevin222004 commented Jul 4, 2023

Uh oh!

github-actions bot commented Jul 4, 2023

Uh oh!

Kevin222004 commented Jul 4, 2023

Uh oh!

github-actions bot commented Jul 4, 2023

Uh oh!

romani commented Jul 30, 2023

Uh oh!

Kevin222004 commented Jul 30, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jul 4, 2023 •

edited

Loading