Skip to content

Issue #13672: Kill mutation for JavadocMethod-5#13340

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JDM5
Sep 24, 2023
Merged

Issue #13672: Kill mutation for JavadocMethod-5#13340
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JDM5

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 2, 2023 •
edited
Loading

Issue #13672: Kill mutation for JavadocMethod-5

Check :-

https://checkstyle.org/checks/javadoc/javadocmethod.html#JavadocMethod

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 210 to 217 in 9097426

<mutation unstable="false">
<sourceFile>JavadocMethodCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass>
<mutatedMethod>setAccessModifiers</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Arrays::copyOf with argument</description>
<lineContent>Arrays.copyOf(accessModifiers, accessModifiers.length);</lineContent>
</mutation>

Explaination

Updated util class

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/df2ff7a8f9969bb2c68d7251a97ffa8b/raw/6a4e81a624fa36483f23b0adcf1fc513ca6df350/JavadocMethod.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Sept-15-Regression-1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 2, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/406d107_2023223450/reports/diff/index.html

@Kevin222004 Kevin222004 closed this Jul 4, 2023
@Kevin222004 Kevin222004 reopened this Jul 4, 2023
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 4, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/406d107_2023062137/reports/diff/index.html

@nrmancuso
Copy link
Copy Markdown
Contributor

nrmancuso commented Aug 23, 2023

@Kevin222004 what do we need to do to get this PR out of draft mode?

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 23, 2023

@nrmancuso This gone delayed because it is decided to cover it later but I will mark them for review mostly in few days after analysis

@Kevin222004 Kevin222004 changed the title Issue #13321: Kill mutation for JavadocMethod-5 Issue #13672: Kill mutation for JavadocMethod-5 Sep 15, 2023
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Sep 15, 2023

Github, generate report

@Kevin222004 Kevin222004 marked this pull request as ready for review September 15, 2023 10:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 15, 2023

Sept-15-Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a50fdaf_2023114126/reports/diff/index.html

@romani
Copy link
Copy Markdown
Member

romani commented Sep 15, 2023

Please fix CIs

@Kevin222004 Kevin222004 force-pushed the JDM5 branch 2 times, most recently from 0ae355e to 21d25be Compare September 16, 2023 05:55
@romani
Copy link
Copy Markdown
Member

romani commented Sep 16, 2023

Checker stit failing

@Kevin222004 Kevin222004 mentioned this pull request Sep 24, 2023
Closed
29 tasks
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Sep 24, 2023

@romani ci green

romani
romani approved these changes Sep 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, known pattern where pitest highlights non functional overprotection of collection usage.

#13142

@romani romani merged commit 50c6672 into checkstyle:master Sep 24, 2023
@romani romani mentioned this pull request Sep 24, 2023
Closed
@Kevin222004 Kevin222004 mentioned this pull request Oct 1, 2023
Closed
33 tasks
@Kevin222004 Kevin222004 mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @nrmancuso @romani @Vyom-Yadav