Skip to content

Issue #13321: Kill mutation for JavadocMethod-2#13337

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JDM2
Jul 4, 2023
Merged

Issue #13321: Kill mutation for JavadocMethod-2#13337
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JDM2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 2, 2023 •
edited
Loading

Issue #13321: Kill mutation for JavadocMethod-2

Check :-

https://checkstyle.org/checks/javadoc/javadocmethod.html#JavadocMethod

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 102 to 109 in 73ec12d

<mutation unstable="false">
<sourceFile>JavadocMethodCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass>
<mutatedMethod>checkComment</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getLineNo</description>
<lineContent>checkReturnTag(tags, ast.getLineNo(), true);</lineContent>
</mutation>

and

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 138 to 145 in 73ec12d

<mutation unstable="false">
<sourceFile>JavadocMethodCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck</mutatedClass>
<mutatedMethod>checkThrowsTags</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>if (validateThrows &amp;&amp; reportExpectedTags) {</lineContent>
</mutation>

Explaination

Test added

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/df2ff7a8f9969bb2c68d7251a97ffa8b/raw/6a4e81a624fa36483f23b0adcf1fc513ca6df350/JavadocMethod.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 2, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/adeb3ac_2023225712/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review July 4, 2023 04:51
@Kevin222004 Kevin222004 mentioned this pull request Jul 4, 2023
Closed
41 tasks
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 4, 2023

ci not related to changes

romani
romani approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit d4b1aec into checkstyle:master Jul 4, 2023
This was referenced Aug 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani