Skip to content

Issue #13321: Kill mutation for SummaryJavaDocCheck-9#13319

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:s9
Jun 29, 2023
Merged

Issue #13321: Kill mutation for SummaryJavaDocCheck-9#13319
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:s9

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 26, 2023 •
edited
Loading

Issue #13321: Kill mutation for SummaryJavaDocCheck-9

Check :-

https://checkstyle.org/checks/javadoc/summaryjavadoc.html#SummaryJavadoc

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 943 to 959 in c3c7ab8

<mutation unstable="false">
<sourceFile>SummaryJavadocCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
<mutatedMethod>isTextPresentInsideHtmlTag</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/String::isBlank</description>
<lineContent>isTextPresentInsideHtmlTag = !nestedChild.getText().isBlank();</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SummaryJavadocCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
<mutatedMethod>isTextPresentInsideHtmlTag</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>isTextPresentInsideHtmlTag = !nestedChild.getText().isBlank();</lineContent>
</mutation>

Explaination

Test added

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 26, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1ecc22f_2023215729/reports/diff/index.html

@Kevin222004 Kevin222004 changed the title Issue #13109: Kill mutation for SummaryJavaDocCheck-9 Issue #13321: Kill mutation for SummaryJavaDocCheck-9 Jun 29, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
41 tasks
@Kevin222004 Kevin222004 marked this pull request as ready for review June 29, 2023 03:37
romani
romani approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI pass

@romani romani merged commit 08da65a into checkstyle:master Jun 29, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani