Issue #13321: Kill mutation for SummaryJavaDocCheck-6 by Kevin222004 · Pull Request #13316 · checkstyle/checkstyle

Kevin222004 · 2023-06-26T18:27:49Z

Issue #13321: Kill mutation for SummaryJavaDocCheck-6

Check :-

https://checkstyle.org/checks/javadoc/summaryjavadoc.html#SummaryJavadoc

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 912 to 919 in 3d8ed42

    
           <mutation unstable="false"> 
        
             <sourceFile>SummaryJavadocCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass> 
        
             <mutatedMethod>isInlineTagPresent</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>|| ast.getType() == JavadocTokenTypes.HTML_ELEMENT</lineContent> 
        
           </mutation>

Explaination

logically this statement has written to pass ast to getInlineTagNodeWithinHtmlElement when it is set to HTML_ELEMENT only but if we remove it then getInlineTagNodeWithinHtmlElement has three condition 1 for HTML_ELEMENT which we don't have any issue 1 JAVADOC_INLINETAG and logic for that is already set in our methd and HTML_TAg is always under the HTML_Element so removal is not issue

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/61eaa69fe98585b6ee1882ca082362bc/raw/316ca02ce9fd290119d9bfc560f2b11e84a1b685/Summary.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Final-Report-1

Kevin222004 · 2023-06-26T18:28:01Z

Github, generate report

github-actions · 2023-06-26T21:03:13Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/16f9a8a_2023210144/reports/diff/index.html

Kevin222004 · 2023-06-29T04:16:50Z

Github, generate report

Kevin222004 · 2023-06-29T04:17:35Z

Github, generate report

github-actions · 2023-06-29T07:09:29Z

New-Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/efb58c9_2023070809/reports/diff/index.html

Kevin222004 · 2023-06-29T07:11:02Z

Github, generate report

github-actions · 2023-06-29T10:35:20Z

New-Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa6b433_2023103315/reports/diff/index.html

github-actions · 2023-06-29T11:44:42Z

New-Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa6b433_2023114404/reports/diff/index.html

romani

ok to merge

Kevin222004 · 2023-06-29T13:43:02Z

@romani minor edit in code
The changes are already mentioned by in reason but at that time I haven't that in my mind

Kevin222004 · 2023-06-29T13:44:10Z

Github, generate report

romani

Items

src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheck.java

github-actions · 2023-06-29T15:15:36Z

Final-Report-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/aaa6fc7_2023150009/reports/diff/index.html

Vyom-Yadav

Ok, with the technical changes, please address the review comment by @romani

romani

ok to merge

romani · 2023-07-02T13:48:56Z

@Kevin222004 , please fix conflict

rdiachenko

lgtm

Kevin222004 force-pushed the s6 branch from 16f9a8a to efb58c9 Compare June 29, 2023 04:16

Kevin222004 changed the title ~~Issue #13109: Kill mutation for SummaryJavaDocCheck-6~~ Issue #13321: Kill mutation for SummaryJavaDocCheck-6 Jun 29, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

Kevin222004 marked this pull request as ready for review June 29, 2023 04:18

romani requested review from Vyom-Yadav, rdiachenko and romani June 29, 2023 04:23

romani assigned Vyom-Yadav Jun 29, 2023

Kevin222004 force-pushed the s6 branch from efb58c9 to fa6b433 Compare June 29, 2023 05:49

romani approved these changes Jun 29, 2023

View reviewed changes

Kevin222004 force-pushed the s6 branch from fa6b433 to aaa6fc7 Compare June 29, 2023 13:41

romani requested changes Jun 29, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheck.java Outdated Show resolved Hide resolved

Vyom-Yadav approved these changes Jul 2, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jul 2, 2023

Kevin222004 force-pushed the s6 branch from aaa6fc7 to 7880689 Compare July 2, 2023 12:53

romani approved these changes Jul 2, 2023

View reviewed changes

romani assigned rdiachenko Jul 2, 2023

romani removed their assignment Jul 2, 2023

Kevin222004 force-pushed the s6 branch from 7880689 to b9194b8 Compare July 2, 2023 15:11

Issue checkstyle#13321: Kill mutation for SummaryJavaDocCheck-6

a9b04d9

Kevin222004 force-pushed the s6 branch from b9194b8 to a9b04d9 Compare July 2, 2023 19:49

rdiachenko approved these changes Jul 5, 2023

View reviewed changes

rdiachenko merged commit 2be5780 into checkstyle:master Jul 5, 2023

Kevin222004 mentioned this pull request Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

	<mutation unstable="false">
	<sourceFile>SummaryJavadocCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
	<mutatedMethod>isInlineTagPresent</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
	<description>removed conditional - replaced equality check with true</description>
	<lineContent>\|\| ast.getType() == JavadocTokenTypes.HTML_ELEMENT</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check :-

Mutation

Explaination

Regression :-

Uh oh!

Kevin222004 commented Jun 26, 2023

Uh oh!

github-actions bot commented Jun 26, 2023

Uh oh!

Kevin222004 commented Jun 29, 2023

Uh oh!

Kevin222004 commented Jun 29, 2023

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

Kevin222004 commented Jun 29, 2023

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

romani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Jun 29, 2023

Uh oh!

Kevin222004 commented Jun 29, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

Vyom-Yadav left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani commented Jul 2, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 26, 2023 •

edited

Loading

romani left a comment •

edited

Loading

Vyom-Yadav left a comment •

edited

Loading