Issue #13321: Kill mutation for SummaryJavaDocCheck-5 by Kevin222004 · Pull Request #13315 · checkstyle/checkstyle

Kevin222004 · 2023-06-26T18:24:11Z

Issue #13321: Kill mutation for SummaryJavaDocCheck-5

Check :-

https://checkstyle.org/checks/javadoc/summaryjavadoc.html#SummaryJavadoc

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 903 to 910 in ce6a111

    
           <mutation unstable="false"> 
        
             <sourceFile>SummaryJavadocCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass> 
        
             <mutatedMethod>isDefinedFirst</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/utils/JavadocUtil::getPreviousSibling with argument</description> 
        
             <lineContent>DetailNode previousSibling = JavadocUtil.getPreviousSibling(inlineSummaryTag);</lineContent> 
        
           </mutation>

Explaination

Loop run 1 time more

Regression :-

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7f8d3df_2023103809/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7cb1b47_2023160922/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/61eaa69fe98585b6ee1882ca082362bc/raw/316ca02ce9fd290119d9bfc560f2b11e84a1b685/Summary.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: change-config-Regression-1

Kevin222004 · 2023-06-26T18:24:25Z

Github, generate report

github-actions · 2023-06-26T20:36:48Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f0af1f_2023203534/reports/diff/index.html

Kevin222004 · 2023-06-28T08:18:17Z

Github, generate report

Kevin222004 · 2023-06-28T09:08:23Z

Github, generate report

github-actions · 2023-06-28T09:25:04Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f0af1f_2023092305/reports/diff/index.html

github-actions · 2023-06-28T10:38:55Z

change-config-Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7f8d3df_2023103809/reports/diff/index.html

romani

Items

src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheck.java

Kevin222004 · 2023-06-28T13:03:38Z

Github, generate report

romani

Ok to merge if reports are clean

github-actions · 2023-06-28T16:31:09Z

change-config-Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7cb1b47_2023160922/reports/diff/index.html

Vyom-Yadav

LGTM!

rdiachenko

lgtm

Kevin222004 changed the title ~~Issue #13109: Kill mutation for SummaryJavaDocCheck-5~~ Issue #13321: Kill mutation for SummaryJavaDocCheck-5 Jun 28, 2023

Kevin222004 mentioned this pull request Jun 28, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

Kevin222004 force-pushed the s5 branch from 9f0af1f to 7f8d3df Compare June 28, 2023 08:30

Kevin222004 marked this pull request as ready for review June 28, 2023 08:30

romani requested changes Jun 28, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheck.java Outdated Show resolved Hide resolved

Issue checkstyle#13321: Kill mutation for SummaryJavaDocCheck-5

7cb1b47

Kevin222004 force-pushed the s5 branch from 7f8d3df to 7cb1b47 Compare June 28, 2023 13:04

romani approved these changes Jun 28, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 28, 2023 13:16

romani assigned Vyom-Yadav Jun 28, 2023

Vyom-Yadav approved these changes Jul 2, 2023

View reviewed changes

Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Jul 2, 2023

rdiachenko approved these changes Jul 3, 2023

View reviewed changes

rdiachenko merged commit 3958c73 into checkstyle:master Jul 3, 2023

Kevin222004 mentioned this pull request Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

	<mutation unstable="false">
	<sourceFile>SummaryJavadocCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
	<mutatedMethod>isDefinedFirst</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/utils/JavadocUtil::getPreviousSibling with argument</description>
	<lineContent>DetailNode previousSibling = JavadocUtil.getPreviousSibling(inlineSummaryTag);</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check :-

Mutation

Explaination

Regression :-

Uh oh!

Kevin222004 commented Jun 26, 2023

Uh oh!

github-actions bot commented Jun 26, 2023

Uh oh!

Kevin222004 commented Jun 28, 2023

Uh oh!

Kevin222004 commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kevin222004 commented Jun 28, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 26, 2023 •

edited

Loading