Skip to content

Issue #13321: Kill mutation for SummaryJavaDocCheck-2#13312

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:s2
Jun 28, 2023
Merged

Issue #13321: Kill mutation for SummaryJavaDocCheck-2#13312
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:s2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 26, 2023 •
edited
Loading

Issue #13321: Kill mutation for SummaryJavaDocCheck-2

Check :-

https://checkstyle.org/checks/javadoc/summaryjavadoc.html#SummaryJavadoc

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 867 to 883 in 3d8ed42

<mutation unstable="false">
<sourceFile>SummaryJavadocCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
<mutatedMethod>getFirstSentence</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/String::contains</description>
<lineContent>if (text.contains(periodSuffix)) {</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SummaryJavadocCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck</mutatedClass>
<mutatedMethod>getFirstSentence</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>if (text.contains(periodSuffix)) {</lineContent>
</mutation>

Explaination

Test added

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/61eaa69fe98585b6ee1882ca082362bc/raw/c74195e574d09886a3406be17a9d46787da9545e/Summary.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 26, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/bb7ffaa_2023201401/reports/diff/index.html

@Kevin222004 Kevin222004 changed the title Issue #13109: Kill mutation for SummaryJavaDocCheck-2 Issue #13321: Kill mutation for SummaryJavaDocCheck-2 Jun 28, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 28, 2023
Closed
41 tasks
@Kevin222004 Kevin222004 marked this pull request as ready for review June 28, 2023 05:03
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 28, 2023

Failure not related to changes

romani
romani approved these changes Jun 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani
Copy link
Copy Markdown
Member

romani commented Jun 28, 2023

@Kevin222004 , no need for regression if just test is added.

@romani romani merged commit 8f4e75f into checkstyle:master Jun 28, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani