Skip to content

Issue #13321: Kill mutation for ConfigurationLoader#13299

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:util
Jul 5, 2023
Merged

Issue #13321: Kill mutation for ConfigurationLoader#13299
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:util

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 23, 2023 •
edited
Loading

Issue #13321: Kill mutation for ConfigurationLoader

Mutation

checkstyle/config/pitest-suppressions/pitest-common-suppressions.xml

Lines 138 to 290 in 03aeb21

<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_0, DTD_CONFIGURATION_NAME_1_0);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_0, DTD_CONFIGURATION_NAME_1_0);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_1, DTD_CONFIGURATION_NAME_1_1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_1, DTD_CONFIGURATION_NAME_1_1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_2, DTD_CONFIGURATION_NAME_1_2);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_2, DTD_CONFIGURATION_NAME_1_2);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_3, DTD_CONFIGURATION_NAME_1_3);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_CS_ID_1_3, DTD_CONFIGURATION_NAME_1_3);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_0, DTD_CONFIGURATION_NAME_1_0);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_0, DTD_CONFIGURATION_NAME_1_0);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_1, DTD_CONFIGURATION_NAME_1_1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_1, DTD_CONFIGURATION_NAME_1_1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_2, DTD_CONFIGURATION_NAME_1_2);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_2, DTD_CONFIGURATION_NAME_1_2);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Map::put</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_3, DTD_CONFIGURATION_NAME_1_3);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Map::put with argument</description>
<lineContent>map.put(DTD_PUBLIC_ID_1_3, DTD_CONFIGURATION_NAME_1_3);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>ConfigurationLoader.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.ConfigurationLoader</mutatedClass>
<mutatedMethod>createIdToResourceNameMap</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.returns.EmptyObjectReturnValsMutator</mutator>
<description>replaced return value with Collections.emptyMap for com/puppycrawl/tools/checkstyle/ConfigurationLoader::createIdToResourceNameMap</description>
<lineContent>return map;</lineContent>
</mutation>

nrmancuso
nrmancuso suggested changes Jun 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items:

@nrmancuso nrmancuso self-assigned this Jun 24, 2023
@nrmancuso nrmancuso requested a review from rdiachenko June 24, 2023 12:34
@nrmancuso nrmancuso assigned rdiachenko and unassigned nrmancuso Jun 24, 2023
rdiachenko
rdiachenko approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 26, 2023
romani
romani requested changes Jun 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani romani assigned romani and unassigned Vyom-Yadav Jun 27, 2023
@romani romani mentioned this pull request Jun 27, 2023
Merged
@Kevin222004 Kevin222004 changed the title Issue #13109: Kill mutation for ConfigurationLoader Issue #13321: Kill mutation for ConfigurationLoader Jun 30, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 30, 2023
Closed
41 tasks
romani
romani requested changes Jul 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good.

last item:

romani
romani requested changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items:

romani
romani requested changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last item

romani
romani approved these changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 1ef4cd7 into checkstyle:master Jul 5, 2023
This was referenced Aug 2, 2023
Closed
Closed
@Kevin222004 Kevin222004 mentioned this pull request Aug 31, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kevin222004 @romani @rdiachenko @nrmancuso @Vyom-Yadav