Skip to content

Issue #13328: Kill mutation for PackageNamesLoader#13286

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:PackageNamesLoader
Jul 1, 2023
Merged

Issue #13328: Kill mutation for PackageNamesLoader#13286
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:PackageNamesLoader

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 21, 2023 •
edited
Loading

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 21, 2023

Failures are not related to changes

@Kevin222004 Kevin222004 force-pushed the PackageNamesLoader branch 3 times, most recently from 9f51622 to 654a733 Compare June 22, 2023 18:23
nrmancuso
nrmancuso suggested changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevin222004 please try:

    private PackageNamesLoader()
            throws ParserConfigurationException, SAXException {
        super(Map.of(
            DTD_PUBLIC_ID, DTD_RESOURCE_NAME,
            DTD_PUBLIC_CS_ID, DTD_RESOURCE_NAME
        ));
    }

And remove method completely.

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 23, 2023

@Kevin222004 please try:

    private PackageNamesLoader()
            throws ParserConfigurationException, SAXException {
        super(Map.of(
            DTD_PUBLIC_ID, DTD_RESOURCE_NAME,
            DTD_PUBLIC_CS_ID, DTD_RESOURCE_NAME
        ));
    }

And remove the method completely.

Done, Thanks :), I don't get this idea in my mind while working on this pr

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 23, 2023

@nrmancuso @romani @stoyanK7 I don't know you are aware of this or not but

[INFO]      [echo] Checkstyle started (checkstyle-input-checks.xml): 23/06/2023 10:16:12 am
[INFO] [checkstyle] Running Checkstyle  on 2109 files
[INFO]      [echo] Checkstyle finished (checkstyle-input-checks.xml): 23/06/2023 10:17:22 am
[INFO]      [echo] Checkstyle started (checkstyle-examples-checks.xml): 23/06/2023 10:16:12 am
[INFO] [checkstyle] Running Checkstyle  on 54 files
[ERROR] [checkstyle] [ERROR] /home/kevin/Desktop/check_style/checkstyle/checkstyle/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/singlespaceseparator/Example1.java:14: Trailing whitespace is not allowed [noTrailingWhitespace]
[ERROR] [checkstyle] [ERROR] /home/kevin/Desktop/check_style/checkstyle/checkstyle/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/singlespaceseparator/Example1.java:15: Trailing whitespace is not allowed [noTrailingWhitespace]
[ERROR] [checkstyle] [ERROR] /home/kevin/Desktop/check_style/checkstyle/checkstyle/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/singlespaceseparator/Example2.java:25: Trailing whitespace is not allowed [noTrailingWhitespace]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:48 min
[INFO] Finished at: 2023-06-23T10:18:46+05:30

This error is from master branch might be from #13272

@stoyanK7 stoyanK7 mentioned this pull request Jun 23, 2023
Merged
@stoyanK7
Copy link
Copy Markdown
Contributor

stoyanK7 commented Jun 23, 2023

@Kevin222004 Thanks for the tip. Kind of expected because we didn't have the checks when these examples got merged. I opened PR #13294. Please disregard these errors.

@nrmancuso nrmancuso force-pushed the PackageNamesLoader branch from b925fc3 to e5112da Compare June 23, 2023 11:37
nrmancuso
nrmancuso approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is rebased, ok to merge.

@nrmancuso nrmancuso requested a review from rdiachenko June 23, 2023 12:28
@Kevin222004 Kevin222004 force-pushed the PackageNamesLoader branch 3 times, most recently from 3e5a3b5 to c55f019 Compare June 26, 2023 07:51
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 26, 2023

@rdiachenko ping

rdiachenko
rdiachenko approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 26, 2023
romani
romani requested changes Jun 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani romani assigned romani and unassigned Vyom-Yadav Jun 27, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
12 tasks
@Kevin222004 Kevin222004 changed the title Issue #13109: Kill mutation for PackageNamesLoader Issue #13328: Kill mutation for PackageNamesLoader Jun 30, 2023
@Kevin222004 Kevin222004 force-pushed the PackageNamesLoader branch 2 times, most recently from f291178 to da96d85 Compare July 1, 2023 09:32
@Kevin222004 Kevin222004 force-pushed the PackageNamesLoader branch from da96d85 to afae0c4 Compare July 1, 2023 09:52
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 1, 2023

@romani only test added still linkcheck failing

romani
romani approved these changes Jul 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

Just tests were added

@romani romani merged commit cf76b65 into checkstyle:master Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kevin222004 @stoyanK7 @romani @rdiachenko @nrmancuso @Vyom-Yadav