Issue #13328: Kill mutation for IllegalInstantiationCheck#13284
Merged
romani merged 1 commit intocheckstyle:masterfrom Jul 1, 2023
Merged
Issue #13328: Kill mutation for IllegalInstantiationCheck#13284romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
Github, generate report |
Contributor
Contributor
Author
|
Github, generate report |
Contributor
2b0116e to
f305402
Compare
romani
requested changes
Jun 27, 2023
|
|
||
| @Override | ||
| public void beginTree(DetailAST rootAST) { | ||
| pkgName = null; |
Member
There was a problem hiding this comment.
As all reset before each file. We need test with the two files execution in one test.
First file with package, second is without package.
Second file should try to trigger violation related to same package name.
Member
There was a problem hiding this comment.
It is hard to find this in real life, because usually all have packages.
But our contract that all files randomly processed, without any context should affect any other file.
Contributor
Author
There was a problem hiding this comment.
#13284 (comment) I have tried this. but I will give time once again to this
12 tasks
romani
approved these changes
Jul 1, 2023
Member
romani
left a comment
There was a problem hiding this comment.
Ok to merge, just test was added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13328: Kill mutation for IllegalInstantiationCheck
Check :
https://checkstyle.org/config_coding.html#IllegalInstantiation
Mutation
checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 30 to 37 in 6324a9d
Explaintaion
Tests Added
Diff Regression config: https://gist.githubusercontent.com/Kevin222004/3bd236a24ed8eacd760e6b12b47f7455/raw/97d7a64aa97fc35488a6db5d7345ee23ae9b9507/olc.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-1