Issue #13501: Kill mutation for AbstarctHeaderCheck by Kevin222004 · Pull Request #13269 · checkstyle/checkstyle

Kevin222004 · 2023-06-20T07:47:24Z

Issue #13501: Kill mutation for AbstarctHeaderCheck

Check

https://checkstyle.org/config_header.html

Mutation

checkstyle/config/pitest-suppressions/pitest-header-suppressions.xml

Lines 3 to 46 in e0d3066

    
           <mutation unstable="false"> 
        
             <sourceFile>AbstractHeaderCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/nio/charset/Charset::name</description> 
        
             <lineContent>StandardCharsets.UTF_8.name()));</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>AbstractHeaderCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/checks/header/AbstractHeaderCheck::createCharset</description> 
        
             <lineContent>private Charset charset = createCharset(System.getProperty(&quot;file.encoding&quot;,</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>AbstractHeaderCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to java/lang/System::getProperty with argument</description> 
        
             <lineContent>private Charset charset = createCharset(System.getProperty(&quot;file.encoding&quot;,</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>AbstractHeaderCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable charset</description> 
        
             <lineContent>private Charset charset = createCharset(System.getProperty(&quot;file.encoding&quot;,</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>AbstractHeaderCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass> 
        
             <mutatedMethod>setCharset</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable charset</description> 
        
             <lineContent>this.charset = createCharset(charset);</lineContent> 
        
           </mutation>

Explaination

at #13268, specific message #13268 (comment)

src/main/java/com/puppycrawl/tools/checkstyle/checks/header/AbstractHeaderCheck.java

romani · 2023-07-31T05:54:40Z

@Kevin222004 , is this duplicate PR of #13268

Can we close it ?

Kevin222004 · 2023-07-31T11:21:28Z

@romani Yes it is created for discussion purpose
#13269 (comment)

after #13268 (comment) I am closing that
and update this in few hours and mark for review

after fixing spotbug

romani · 2023-07-31T13:56:51Z

Please add suppression for Checker with same comment above https://github.com/checkstyle/checkstyle/actions/runs/5714370827/job/15481588407?pr=13269#step:6:1658
Please also mention that it is conflict with pitest but value pitest above checker.

Kevin222004 · 2023-07-31T16:00:07Z

@romani #13269 (comment) done

romani

Items:

config/checkstyle-checks.xml

romani

Last:

src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java

romani

Ok to merge

Vyom-Yadav

LGTM! @Kevin222004 @romani I think we discussed creating an issue about removing file.encoding

romani · 2023-08-04T13:35:16Z

After deeper analysis, I recalled it, it is not required, this property is not effective at all. It remnants of something old.

rdiachenko

lgtm

rdiachenko · 2023-08-06T19:27:43Z

rebased

Kevin222004 mentioned this pull request Jun 20, 2023

minor: Kill Mutation for AbstractHeaderCheck #13268

Closed

Kevin222004 force-pushed the ABC3 branch from 41290dd to 8ef2ac3 Compare June 20, 2023 08:23

romani reviewed Jun 27, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/header/AbstractHeaderCheck.java Outdated Show resolved Hide resolved

Kevin222004 mentioned this pull request Jun 29, 2023

Targeted Pitest Mutation in July 2023 #13328

Closed

12 tasks

Kevin222004 changed the title ~~Issue #13109: Kill mutation for AbstarctHeaderCheck~~ Issue #13328: Kill mutation for AbstarctHeaderCheck Jun 30, 2023

Kevin222004 force-pushed the ABC3 branch from 8ef2ac3 to d21cd81 Compare June 30, 2023 17:00

Kevin222004 force-pushed the ABC3 branch from d21cd81 to a5bdd2f Compare July 22, 2023 07:48

Kevin222004 force-pushed the ABC3 branch from a5bdd2f to 4de37ce Compare July 31, 2023 11:47

Kevin222004 marked this pull request as ready for review July 31, 2023 11:48

Kevin222004 force-pushed the ABC3 branch from 4de37ce to 91d5a90 Compare July 31, 2023 11:59

Kevin222004 force-pushed the ABC3 branch from 91d5a90 to 70cee4c Compare July 31, 2023 15:59

romani requested changes Aug 1, 2023

View reviewed changes

config/checkstyle-checks.xml Outdated Show resolved Hide resolved

This was referenced Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

Resolve pitest survivals in modules - 3 #13501

Closed

Kevin222004 changed the title ~~Issue #13328: Kill mutation for AbstarctHeaderCheck~~ Issue #13501: Kill mutation for AbstarctHeaderCheck Aug 2, 2023

Kevin222004 force-pushed the ABC3 branch 3 times, most recently from 199b379 to 856e522 Compare August 3, 2023 16:54

romani requested changes Aug 4, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java Show resolved Hide resolved

romani approved these changes Aug 4, 2023

View reviewed changes

romani requested a review from Vyom-Yadav August 4, 2023 04:46

romani assigned Vyom-Yadav Aug 4, 2023

Vyom-Yadav approved these changes Aug 4, 2023

View reviewed changes

Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Aug 4, 2023

Vyom-Yadav requested a review from rdiachenko August 4, 2023 05:56

Kevin222004 force-pushed the ABC3 branch from 856e522 to 5626fef Compare August 5, 2023 19:24

rdiachenko approved these changes Aug 6, 2023

View reviewed changes

Issue checkstyle#13501: Kill mutation for AbstarctHeaderCheck

25121dd

rdiachenko force-pushed the ABC3 branch from 5626fef to 25121dd Compare August 6, 2023 19:27

romani merged commit c4f8052 into checkstyle:master Aug 6, 2023

	<mutation unstable="false">
	<sourceFile>AbstractHeaderCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/nio/charset/Charset::name</description>
	<lineContent>StandardCharsets.UTF_8.name()));</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>AbstractHeaderCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/checks/header/AbstractHeaderCheck::createCharset</description>
	<lineContent>private Charset charset = createCharset(System.getProperty("file.encoding",</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>AbstractHeaderCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to java/lang/System::getProperty with argument</description>
	<lineContent>private Charset charset = createCharset(System.getProperty("file.encoding",</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>AbstractHeaderCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable charset</description>
	<lineContent>private Charset charset = createCharset(System.getProperty("file.encoding",</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>AbstractHeaderCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.AbstractHeaderCheck</mutatedClass>
	<mutatedMethod>setCharset</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable charset</description>
	<lineContent>this.charset = createCharset(charset);</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check

Mutation

Explaination

Uh oh!

Uh oh!

romani commented Jul 31, 2023

Uh oh!

Kevin222004 commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Jul 31, 2023

Uh oh!

Kevin222004 commented Jul 31, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

romani commented Aug 4, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko commented Aug 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 20, 2023 •

edited

Loading

Kevin222004 commented Jul 31, 2023 •

edited

Loading