Skip to content

Issue #13109: Kill mutation for RegexpHeaderCheck#13261

Merged
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:ABC1
Jun 26, 2023
Merged

Issue #13109: Kill mutation for RegexpHeaderCheck#13261
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:ABC1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 19, 2023 •
edited
Loading

Issue #13109: Kill mutation for RegexpHeaderCheck

Check :-

https://checkstyle.org/config_header.html#RegexpHeader

Mutation

checkstyle/config/pitest-suppressions/pitest-header-suppressions.xml

Lines 48 to 64 in 7d35a52

<mutation unstable="false">
<sourceFile>RegexpHeaderCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.RegexpHeaderCheck</mutatedClass>
<mutatedMethod>postProcessHeaderLines</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/List::size</description>
<lineContent>+ (headerRegexps.size() + 1)</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>RegexpHeaderCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.header.RegexpHeaderCheck</mutatedClass>
<mutatedMethod>postProcessHeaderLines</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/List::add</description>
<lineContent>headerRegexps.add(BLANK_LINE);</lineContent>
</mutation>

Explaination

Test added

rdiachenko
rdiachenko reviewed Jun 22, 2023
View reviewed changes
src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java Outdated
}

@Test
public void testHeaderWithInvalidRegexp2() throws Exception {
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is almost the same as testHeaderWithInvalidRegexp() with the difference in the input file. If you keep existing test and just update its input and expected exception message, would that be enough, so we don't need testHeaderWithInvalidRegexp2()?

Copy link
Copy Markdown
Contributor Author

@Kevin222004 Kevin222004 Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes That's enough, I have updated

Copy link
Copy Markdown
Contributor Author

@Kevin222004 Kevin222004 Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semaphore is failing in lots of pr

Copy link
Copy Markdown
Member

@romani romani Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's not be blocked by semaphore.

@rdiachenko rdiachenko self-assigned this Jun 22, 2023
romani
romani approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from Vyom-Yadav June 23, 2023 02:08
Vyom-Yadav
Vyom-Yadav approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rdiachenko
rdiachenko approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit 7e1dd4a into checkstyle:master Jun 26, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav