Skip to content

Issue #13109: Kill mutation for MultipleStringLiteralCheck#13241

Merged
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:Multi
Jun 26, 2023
Merged

Issue #13109: Kill mutation for MultipleStringLiteralCheck#13241
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:Multi

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 17, 2023

Issue #13109: Kill mutation for MultipleStringLiteralCheck

Check :-

https://checkstyle.org/config_coding.html#MultipleStringLiterals

Mutation

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 57 to 64 in 3f25c37

<mutation unstable="false">
<sourceFile>MultipleStringLiteralsCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.MultipleStringLiteralsCheck</mutatedClass>
<mutatedMethod>isInIgnoreOccurrenceContext</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getParent with receiver</description>
<lineContent>token.getParent() != null;</lineContent>
</mutation>

Explaination

The loops run one time more.

Regression

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/7d3bd1d1b0d117d9b3d1a23fb9a7ae26/raw/d1f8aec7b4247bda070e645445515de2b8421c7a/MultipleStringLiterals.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: R1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 17, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 17, 2023

R1 :
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c8b21f2_2023102735/reports/diff/index.html

romani
romani approved these changes Jun 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested review from Vyom-Yadav and rdiachenko June 18, 2023 23:56
Vyom-Yadav
Vyom-Yadav approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Jun 23, 2023
rdiachenko
rdiachenko approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit 6073cd4 into checkstyle:master Jun 26, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav