Issue #13109: Kill mutation for NestedIfDepthCheck#13235
Merged
romani merged 1 commit intocheckstyle:masterfrom Jun 24, 2023
Merged
Issue #13109: Kill mutation for NestedIfDepthCheck#13235romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
Github, generate report |
Contributor
Contributor
Author
|
Github, generate report |
Contributor
Member
|
Conflict, resolve please |
Contributor
Author
|
done |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13109: Kill mutation for NestedIfDepthCheck
Check :-
https://checkstyle.org/config_coding.html#NestedIfDepth
Mutation
checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 102 to 109 in 3f25c37
Explaination
All the values will increase by visit token and decrement by leave Token so I don't see we should require to reset the value using beginTree because at the end it will be reset by leaveToken
but lets see Regression
Regression
Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/033e5f2_2023175528/reports/diff/index.html
Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/033e5f2_2023190546/reports/diff/index.html
Diff Regression config: https://gist.githubusercontent.com/Kevin222004/b79c1d6f36c0d6db4516ff0aa57b8aee/raw/6e708ea645d0a75bfde0bd2baaff2adbf01730e0/NestedIf.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: R1