Skip to content

Issue #13109: Kill mutation for UnusedImportCheck-2#13230

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:uic2
Jun 18, 2023
Merged

Issue #13109: Kill mutation for UnusedImportCheck-2#13230
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:uic2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 15, 2023 •
edited
Loading

Issue #13109: Kill mutation for UnusedImportCheck-2

Check :
https://checkstyle.org/config_imports.html#UnusedImports

Mutation covered

checkstyle/config/pitest-suppressions/pitest-imports-suppressions.xml

Lines 174 to 181 in c7f3688

<mutation unstable="false">
<sourceFile>UnusedImportsCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck</mutatedClass>
<mutatedMethod>collectReferencesFromJavadoc</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to java/util/stream/Stream::filter with receiver</description>
<lineContent>.filter(JavadocTag::canReferenceImports)</lineContent>
</mutation>

Explaination

Test added

Regression

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/27bfdb307fbeb7459ca132bcc5104c5b/raw/0d6a50d1d09d825a0947355e7ba1af3f80d94d74/UnusedImport.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: R2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 15, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 15, 2023

R1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/11344fb_2023101409/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review June 15, 2023 12:49
romani
romani requested changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 15, 2023

can you please re-run circle-ci

@romani
Copy link
Copy Markdown
Member

romani commented Jun 18, 2023

Link check is resolved , just rebase, it is not related CI execution to your update, we will ignore it.

romani
romani requested changes Jun 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last item:

romani
romani requested changes Jun 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do me last favor:

@romani
Copy link
Copy Markdown
Member

romani commented Jun 18, 2023

After fix , please rebase to avoid CI failure

romani
romani approved these changes Jun 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 47ba544 into checkstyle:master Jun 18, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani