Skip to content

Issue #13109: Kill mutation for CustomImportOrderCheck#13203

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cic1
Jun 13, 2023
Merged

Issue #13109: Kill mutation for CustomImportOrderCheck#13203
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cic1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 12, 2023

Issue #13109: Kill mutation for CustomImportOrderCheck

Check :-
https://checkstyle.org/config_imports.html#CustomImportOrder

Mutation Covered

checkstyle/config/pitest-suppressions/pitest-imports-suppressions.xml

Lines 2 to 19 in 3f77dd1

<suppressedMutations>
<mutation unstable="false">
<sourceFile>CustomImportOrderCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck</mutatedClass>
<mutatedMethod>&lt;init&gt;</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/regex/Pattern::compile</description>
<lineContent>private Pattern specialImportsRegExp = Pattern.compile(&quot;^$&quot;);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>CustomImportOrderCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck</mutatedClass>
<mutatedMethod>&lt;init&gt;</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable specialImportsRegExp</description>
<lineContent>private Pattern specialImportsRegExp = Pattern.compile(&quot;^$&quot;);</lineContent>
</mutation>

Explaination

Test cases added

romani
romani requested changes Jun 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@romani
Copy link
Copy Markdown
Member

romani commented Jun 12, 2023

Please pull latest our master, semaphore is fixed

romani
romani approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 61fbdfb into checkstyle:master Jun 13, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani