Issue #13109: Kill mutation for IllegalTokenTextCheck by Kevin222004 · Pull Request #13200 · checkstyle/checkstyle

Kevin222004 · 2023-06-11T13:49:31Z

Issue #13109: Kill mutation for IllegalTokenTextCheck

Check

https://checkstyle.org/config_coding.html#IllegalTokenText

Mutation covered

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 57 to 73 in eaed451

    
           <mutation unstable="false"> 
        
             <sourceFile>IllegalTokenTextCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.IllegalTokenTextCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/util/regex/Pattern::compile</description> 
        
             <lineContent>private Pattern format = Pattern.compile(formatString);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>IllegalTokenTextCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.IllegalTokenTextCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable format</description> 
        
             <lineContent>private Pattern format = Pattern.compile(formatString);</lineContent> 
        
           </mutation>

Explaintaion

Test cases added

Regression

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/13ca2532a9d40774066ac08c558f4111/raw/e41a49826864eac40ca16a3d2865cfb993255e98/IllegalTokenText.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Report-2

Kevin222004 · 2023-06-11T14:03:31Z

Github, generate report

github-actions · 2023-06-11T14:04:39Z

Report generation failed on phase "parse_body",
step "Parsing content of PR description".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5235848546

Kevin222004 · 2023-06-11T14:05:25Z

Github, generate report

romani · 2023-06-11T15:19:25Z

Setter is executed only when property is defined in config.
To reproduce mutation you need to play with config that is default, no properties are defined. In this case default values on field declaration are in play.

Kevin222004 · 2023-06-11T15:51:41Z

I really missed it. such one-sided thinking :)

github-actions · 2023-06-11T16:16:17Z

Report-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9d20aad_2023161459/reports/diff/index.html

romani

Items

romani · 2023-06-12T04:47:13Z

...rawl/tools/checkstyle/checks/coding/illegaltokentext/InputIllegalTokenTextDefaultFormat.java

+
+public class InputIllegalTokenTextDefaultFormat {
+    public void myTest() {
+        String test = "a href"; // ok


Please remove all ok comments and never use them, it was our mistake to start to use them.

If i am not wrong the ant task will be failed in mvn clean verify

Share it as text

Ok, put one unrelated comment over class, to juy cheat this Check. To avoid dealing with this Check, I will try to disable it in separate PR.

[INFO] --- maven-antrun-plugin:3.1.0:run (ant-phase-verify) @ checkstyle --- [INFO] Executing tasks [INFO] [echo] Checkstyle started (checkstyle-checks.xml): 12/06/2023 10:32:21 am [INFO] [checkstyle] Running Checkstyle on 1507 files [INFO] [echo] Checkstyle finished (checkstyle-checks.xml) : 12/06/2023 10:33:26 am [INFO] [echo] Checkstyle started (checkstyle-non-main-files-checks.xml): 12/06/2023 10:32:21 am [INFO] [checkstyle] Running Checkstyle on 3657 files [INFO] [echo] Checkstyle finished (checkstyle-non-main-files-checks.xml): 12/06/2023 10:33:26 am [INFO] [echo] [INFO] [echo] Checkstyle started (checkstyle-resources-checks.xml): 12/06/2023 10:32:21 am [INFO] [checkstyle] Running Checkstyle on 3307 files [INFO] [echo] Checkstyle finished (checkstyle-resources-checks.xml): 12/06/2023 10:33:26 am [INFO] [echo] Checkstyle started (checkstyle-input-checks.xml): 12/06/2023 10:32:21 am [INFO] [checkstyle] Running Checkstyle on 2102 files [ERROR] [checkstyle] [ERROR] /home/kevin/Desktop/check_style/checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/illegaltokentext/InputIllegalTokenTextDefaultFormat.java:0: All check input files in the 'src/(it|test)/resources*/' folder must have trailing comments "// ok" and/or "// violation". [StyleValidationCommentInInputs] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 03:16 min [INFO] Finished at: 2023-06-12T10:35:27+05:30 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.1.0:run (ant-phase-verify) on project checkstyle: An Ant BuildException has occured: The following error occurred while executing this line: [ERROR] /home/kevin/Desktop/check_style/checkstyle/checkstyle/config/ant-phase-verify.xml:192: Got 1 errors and 0 warnings. [ERROR] around Ant part ...<ant antfile="config/ant-phase-verify.xml" />... @ 6:50 in /home/kevin/Desktop/check_style/checkstyle/checkstyle/target/antrun/build-main.xml [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging.

@Kevin222004 Simply remove trailing //ok comments from variable defs and place one at class level i.e.

public class InputIllegalTokenTextDefaultFormat { // ok

Request to remove ok comments - #13213

Vyom-Yadav

LGTM!

romani

Ok to merge

rdiachenko

lgtm

Kevin222004 force-pushed the ITTC1 branch from 9d20aad to 4aad65c Compare June 11, 2023 14:26

romani requested review from Vyom-Yadav, rdiachenko and romani June 11, 2023 15:19

Kevin222004 force-pushed the ITTC1 branch from 4aad65c to af12916 Compare June 11, 2023 15:50

Kevin222004 force-pushed the ITTC1 branch from af12916 to 1554114 Compare June 11, 2023 16:17

romani requested changes Jun 12, 2023

View reviewed changes

Kevin222004 force-pushed the ITTC1 branch from 1554114 to ebd09c1 Compare June 12, 2023 05:23

Issue checkstyle#13109: Kill mutation for IllegalTokenTextCheck

9534440

Kevin222004 force-pushed the ITTC1 branch from ebd09c1 to 9534440 Compare June 12, 2023 05:29

Vyom-Yadav approved these changes Jun 12, 2023

View reviewed changes

romani approved these changes Jun 12, 2023

View reviewed changes

romani assigned rdiachenko Jun 12, 2023

rdiachenko approved these changes Jun 12, 2023

View reviewed changes

rdiachenko assigned romani and unassigned rdiachenko Jun 12, 2023

romani mentioned this pull request Jun 13, 2023

Remove '//ok' comments from Input files #13213

Closed

romani merged commit 398035a into checkstyle:master Jun 13, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

	<mutation unstable="false">
	<sourceFile>IllegalTokenTextCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.IllegalTokenTextCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/util/regex/Pattern::compile</description>
	<lineContent>private Pattern format = Pattern.compile(formatString);</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>IllegalTokenTextCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.IllegalTokenTextCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable format</description>
	<lineContent>private Pattern format = Pattern.compile(formatString);</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check

Mutation covered

Explaintaion

Regression

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

romani commented Jun 11, 2023

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romani Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 11, 2023 •

edited

Loading

romani Jun 12, 2023 •

edited

Loading