Issue #13109: Kill mutation for MultipleVariableDeclarationsCheck by Kevin222004 · Pull Request #13197 · checkstyle/checkstyle

Kevin222004 · 2023-06-11T11:19:08Z

Issue #13109: Kill mutation for MultipleVariableDeclarationsCheck

Check

https://checkstyle.org/config_coding.html#MultipleVariableDeclarations

Mutation

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 66 to 82 in 3f25c37

    
           <mutation unstable="false"> 
        
             <sourceFile>MultipleVariableDeclarationsCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck</mutatedClass> 
        
             <mutatedMethod>getLastNode</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck::getLastNode with argument</description> 
        
             <lineContent>currentNode = getLastNode(child);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>MultipleVariableDeclarationsCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck</mutatedClass> 
        
             <mutatedMethod>visitToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/utils/CheckUtil::getFirstNode with argument</description> 
        
             <lineContent>final DetailAST firstNextNode = CheckUtil.getFirstNode(nextNode);</lineContent> 
        
           </mutation>

Explaination

Test added

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47e3287_2023184215/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47e3287_2023211141/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/201dae231798cb048eca902b7b21d6ea/raw/6655ab3c5cff01a88fcbc704e671b6be0c441a98/MultipleVariableDeclarationsCheck.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Latest-Report-2

Kevin222004 · 2023-06-11T11:19:35Z

Github, generate report

github-actions · 2023-06-11T13:14:41Z

Report-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/57fa60e_2023131327/reports/diff/index.html

Kevin222004 · 2023-06-11T13:17:29Z

Github, generate report

github-actions · 2023-06-11T14:56:11Z

Report-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/57fa60e_2023145512/reports/diff/index.html

Kevin222004 · 2023-06-16T17:27:30Z

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/18962/workflows/ecff56cf-2820-438a-ae44-8bb5be478e44/jobs/309926 similar error noticed in multiple pr

Kevin222004 · 2023-06-16T17:27:54Z

Github, generate report

github-actions · 2023-06-16T19:12:45Z

Latest-Report-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47e3287_2023184215/reports/diff/index.html

Kevin222004 · 2023-06-16T19:19:54Z

Github, generate report

github-actions · 2023-06-16T21:12:53Z

Latest-Report-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47e3287_2023211141/reports/diff/index.html

rdiachenko

lgtm

Vyom-Yadav · 2023-06-23T09:53:33Z

@Kevin222004 This is not the correct analysis, you missed 2 test cases:

void method4() {                                                                    
    int c = // violation 'Only one variable definition per line allowed.'           
            12; int a = 1;                                                          
                                                                                    
    int cb = 12; java. // violation 'Only one variable definition per line allowed.'
            lang.String                                                             
            asd = "123";                                                            
}

This is being detected by the code in the master branch, but since you resort to final DetailAST lastNode = ast.getLastChild(); the last child has more children, which are on the next line and nextNode directly instead of final DetailAST firstNextNode = CheckUtil.getFirstNode(nextNode); this is not being detected anymore.

I don't think the current logic is redundant, please use the above-mentioned test cases killing the mutation.

Vyom-Yadav

#13197 (comment)

Kevin222004 · 2023-06-23T12:51:36Z

his is being detected by the code in the master branch, but since you resort to final DetailAST lastNode = ast.getLastChild(); the last child has more children, which are on the next line and nextNode directly instead of final DetailAST firstNextNode = CheckUtil.getFirstNode(nextNode); this is not being detected anymore.

Yes you are right I missed this test and my calculation become wrong

romani · 2023-06-27T13:08:09Z

@Kevin222004 , please resolve conflict and and lets finalize review.

…sCheck

romani · 2023-06-27T15:14:55Z

Circleci is restarted

romani

Ok to merge

romani

Ok to merge

Vyom-Yadav

LGTM!

Kevin222004 force-pushed the MultipleVariableDeclarationsCheck branch from 57fa60e to 47e3287 Compare June 16, 2023 17:18

Kevin222004 marked this pull request as ready for review June 16, 2023 17:28

Kevin222004 force-pushed the MultipleVariableDeclarationsCheck branch from 47e3287 to fd0a037 Compare June 18, 2023 18:16

romani requested review from Vyom-Yadav, rdiachenko and romani June 19, 2023 14:37

romani assigned rdiachenko Jun 19, 2023

rdiachenko approved these changes Jun 19, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 19, 2023

Kevin222004 mentioned this pull request Jun 21, 2023

Issue #13109: Kill mutation for MultipleVariableDeclarationsCheck2 #13198

Closed

Vyom-Yadav suggested changes Jun 23, 2023

View reviewed changes

Kevin222004 force-pushed the MultipleVariableDeclarationsCheck branch from fd0a037 to b203ae3 Compare June 23, 2023 12:49

Kevin222004 force-pushed the MultipleVariableDeclarationsCheck branch 3 times, most recently from bde4677 to c1356b7 Compare June 26, 2023 08:28

Issue checkstyle#13109: Kill mutation for MultipleVariableDeclaration…

b6cb59f

…sCheck

Kevin222004 force-pushed the MultipleVariableDeclarationsCheck branch from c1356b7 to b6cb59f Compare June 27, 2023 13:26

romani approved these changes Jun 27, 2023

View reviewed changes

Vyom-Yadav approved these changes Jun 27, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 27, 2023

romani merged commit e15fcdb into checkstyle:master Jun 27, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

	<mutation unstable="false">
	<sourceFile>MultipleVariableDeclarationsCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck</mutatedClass>
	<mutatedMethod>getLastNode</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck::getLastNode with argument</description>
	<lineContent>currentNode = getLastNode(child);</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>MultipleVariableDeclarationsCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck</mutatedClass>
	<mutatedMethod>visitToken</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/utils/CheckUtil::getFirstNode with argument</description>
	<lineContent>final DetailAST firstNextNode = CheckUtil.getFirstNode(nextNode);</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check

Mutation

Explaination

Regression

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav commented Jun 23, 2023

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Jun 23, 2023

Uh oh!

romani commented Jun 27, 2023

Uh oh!

romani commented Jun 27, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 11, 2023 •

edited

Loading