Issue #13109: Kill mutation for OneStatementPerLineCheck-2 by Kevin222004 · Pull Request #13193 · checkstyle/checkstyle

Kevin222004 · 2023-06-10T06:24:50Z

Issue #13109: Kill mutation for OneStatementPerLineCheck-2

check

https://checkstyle.org/config_coding.html#OneStatementPerLine

Mutation

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 183 to 217 in c5566a6

    
           <mutation unstable="false"> 
        
             <sourceFile>OneStatementPerLineCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable forStatementEnd</description> 
        
             <lineContent>private int forStatementEnd = -1;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>OneStatementPerLineCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable lambdaStatementEnd</description> 
        
             <lineContent>private int lambdaStatementEnd = -1;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>OneStatementPerLineCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable lastStatementEnd</description> 
        
             <lineContent>private int lastStatementEnd = -1;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>OneStatementPerLineCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable lastVariableResourceStatementEnd</description> 
        
             <lineContent>private int lastVariableResourceStatementEnd = -1;</lineContent> 
        
           </mutation>

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/88d109b_2023082948/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2907cd7_2023142213/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/3bd236a24ed8eacd760e6b12b47f7455/raw/97d7a64aa97fc35488a6db5d7345ee23ae9b9507/olc.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

Kevin222004 · 2023-06-10T06:25:11Z

Github, generate report

github-actions · 2023-06-10T08:30:54Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/88d109b_2023082948/reports/diff/index.html

romani

Not all -1 are removed from code.

Real life code usually is not single line for whole class.
We kill survival try to make file that has whole code of class on single line.

It might be a reason on such -1 a fact that several years ago, checkstyle counted first line as 0 index. So not real become -1.
I think we now updated code to make first line as 1, so migration to 0 as non-existing, is ok.

Please double check, show evidences, and let's proceed.

Kevin222004 · 2023-06-16T13:13:35Z

Github, generate report

Kevin222004 · 2023-06-16T13:15:27Z

@romani I have added a test file in which all the code is in the same line
and change all the values to be 0.

Test look good their is no issue

github-actions · 2023-06-16T14:33:06Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2907cd7_2023142213/reports/diff/index.html

romani

Items

pom.xml

romani

Ok to merge

rdiachenko

lgtm

Vyom-Yadav

LGTM!

romani · 2023-06-24T17:58:55Z

Conflict

Kevin222004 force-pushed the oneStat branch from 88d109b to 071b012 Compare June 10, 2023 07:00

romani requested changes Jun 10, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 10, 2023 22:39

romani self-assigned this Jun 10, 2023

Kevin222004 force-pushed the oneStat branch from 071b012 to 2907cd7 Compare June 16, 2023 13:13

Kevin222004 force-pushed the oneStat branch 2 times, most recently from d86ae08 to d36247a Compare June 18, 2023 18:17

romani requested changes Jun 18, 2023

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Kevin222004 force-pushed the oneStat branch from d36247a to 39f2bff Compare June 18, 2023 19:41

romani approved these changes Jun 18, 2023

View reviewed changes

romani assigned rdiachenko and unassigned romani Jun 18, 2023

rdiachenko approved these changes Jun 21, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 21, 2023

Vyom-Yadav approved these changes Jun 23, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 23, 2023

Issue checkstyle#13109: Kill mutation for OneStatementPerLineCheck-2

24be5bb

Kevin222004 force-pushed the oneStat branch from 39f2bff to 24be5bb Compare June 24, 2023 18:07

romani merged commit 6cbca88 into checkstyle:master Jun 24, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13109: Kill mutation for OneStatementPerLineCheck-2#13193

Issue #13109: Kill mutation for OneStatementPerLineCheck-2#13193
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:oneStat

Kevin222004 commented Jun 10, 2023 •

edited

Loading

Uh oh!

Kevin222004 commented Jun 10, 2023

Uh oh!

github-actions bot commented Jun 10, 2023

Uh oh!

romani left a comment

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

romani left a comment

Uh oh!

Uh oh!

romani left a comment

Uh oh!

rdiachenko left a comment

Uh oh!

Vyom-Yadav left a comment

Uh oh!

romani commented Jun 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>OneStatementPerLineCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable forStatementEnd</description>
	<lineContent>private int forStatementEnd = -1;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>OneStatementPerLineCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable lambdaStatementEnd</description>
	<lineContent>private int lambdaStatementEnd = -1;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>OneStatementPerLineCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable lastStatementEnd</description>
	<lineContent>private int lastStatementEnd = -1;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>OneStatementPerLineCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable lastVariableResourceStatementEnd</description>
	<lineContent>private int lastVariableResourceStatementEnd = -1;</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

check

Mutation

Regression

Uh oh!

Kevin222004 commented Jun 10, 2023

Uh oh!

github-actions bot commented Jun 10, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

Kevin222004 commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

romani commented Jun 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 10, 2023 •

edited

Loading