Issue #13328: Kill mutation for HiddenField by Kevin222004 · Pull Request #13182 · checkstyle/checkstyle

Kevin222004 · 2023-06-08T17:16:05Z

Issue #13328: Kill mutation for HiddenField

Check:-

https://checkstyle.org/checks/coding/hiddenfield.html#HiddenField

Mutations

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 21 to 28 in f4a33f9

    
           <mutation unstable="false"> 
        
             <sourceFile>HiddenFieldCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck$FieldFrame</mutatedClass> 
        
             <mutatedMethod>containsInstanceField</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>return instanceFields.contains(field)</lineContent> 
        
           </mutation>

Explaination

Tried various ways but no test cases were found.

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/76d0b0f_2023195339/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/76d0b0f_2023170225/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/e922f9f79f4b5245caba9b44cd2d1f0d/raw/50a61d0d72c5a09bd74a383907fe0021d28f1763/hidden.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

Kevin222004 · 2023-06-08T17:16:16Z

Github, generate report

github-actions · 2023-06-08T17:19:35Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5213953279

Kevin222004 · 2023-06-08T17:30:54Z

Github, generate report

github-actions · 2023-06-08T19:56:39Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/76d0b0f_2023195339/reports/diff/index.html

Kevin222004 · 2023-06-11T16:05:19Z

Github, generate report

github-actions · 2023-06-11T17:03:14Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/76d0b0f_2023170225/reports/diff/index.html

nrmancuso

Fields should always have a parent, regression turned up nothing, I am good to merge.

romani

Ok to merge

rdiachenko

lgtm

rdiachenko · 2023-07-30T10:39:32Z

rebased

romani · 2023-07-30T12:28:34Z

Pitest failure test (common) https://github.com/checkstyle/checkstyle/actions/runs/5705747270/job/15460721241?pr=13182#step:7:24

diff --git a/config/pitest-suppressions/pitest-common-suppressions.xml b/config/pitest-suppressions/pitest-common-suppressions.xml
index 1ed5890..3b8d487 100644
--- a/config/pitest-suppressions/pitest-common-suppressions.xml
+++ b/config/pitest-suppressions/pitest-common-suppressions.xml
@@ -45,6 +45,15 @@
     <lineContent>final String stripped = CommonUtil.relativizeAndNormalizePath(basedir, fileName);</lineContent>
   </mutation>
 
+  <mutation unstable="false">
+    <sourceFile>Checker.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.Checker</mutatedClass>
+    <mutatedMethod>finishLocalSetup</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.VoidMethodCallMutator</mutator>
+    <description>removed call to com/puppycrawl/tools/checkstyle/LocalizedMessage::setLocale</description>
+    <lineContent>LocalizedMessage.setLocale(locale);</lineContent>
+  </mutation>
+

Very strange.
Need to be restarted few times.

romani · 2023-07-30T14:14:55Z

pitest is green, restarted one more time .

romani · 2023-07-30T14:16:25Z

@rdiachenko , restart it one more time on your next code review time.

rdiachenko · 2023-07-31T20:50:25Z

@rdiachenko , restart it one more time on your next code review time.

done

Kevin222004 changed the title ~~Issue #13109: Kill mutation for HiddenField~~ Issue #13328: Kill mutation for HiddenField Jul 23, 2023

Kevin222004 force-pushed the HFC1 branch from 76d0b0f to dc19a6c Compare July 23, 2023 13:16

Kevin222004 marked this pull request as ready for review July 23, 2023 13:18

nrmancuso approved these changes Jul 29, 2023

View reviewed changes

nrmancuso requested a review from romani July 29, 2023 18:08

nrmancuso assigned romani Jul 29, 2023

romani approved these changes Jul 29, 2023

View reviewed changes

romani requested a review from rdiachenko July 29, 2023 18:16

romani assigned rdiachenko and unassigned romani Jul 29, 2023

rdiachenko approved these changes Jul 30, 2023

View reviewed changes

Issue checkstyle#13328: Kill mutation for HiddenField

60c8f59

rdiachenko force-pushed the HFC1 branch from dc19a6c to 60c8f59 Compare July 30, 2023 10:39

romani merged commit 2bd1a8b into checkstyle:master Aug 1, 2023

Kevin222004 mentioned this pull request Aug 5, 2023

Resolve pitest survivals in modules - 3 #13501

Closed

61 tasks

	<mutation unstable="false">
	<sourceFile>HiddenFieldCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck$FieldFrame</mutatedClass>
	<mutatedMethod>containsInstanceField</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
	<description>removed conditional - replaced equality check with true</description>
	<lineContent>return instanceFields.contains(field)</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check:-

Mutations

Explaination

Regression

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

Kevin222004 commented Jun 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

nrmancuso left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko commented Jul 30, 2023

Uh oh!

romani commented Jul 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Jul 30, 2023

Uh oh!

romani commented Jul 30, 2023

Uh oh!

rdiachenko commented Jul 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 8, 2023 •

edited

Loading

romani commented Jul 30, 2023 •

edited

Loading