Issue #13109: Kill mutation for FullIdent.java by Kevin222004 · Pull Request #13178 · checkstyle/checkstyle

Kevin222004 · 2023-06-07T16:40:18Z

Issue #13109: Kill mutation for FullIdent.java

Mutation Covered

checkstyle/config/pitest-suppressions/pitest-api-suppressions.xml

Lines 57 to 73 in b8753a7

    
           <mutation unstable="false"> 
        
             <sourceFile>FullIdent.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.api.FullIdent</mutatedClass> 
        
             <mutatedMethod>isArrayTypeDeclaration</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getFirstChild with receiver</description> 
        
             <lineContent>DetailAST expression = arrayDeclarator.getFirstChild();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>FullIdent.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.api.FullIdent</mutatedClass> 
        
             <mutatedMethod>isArrayTypeDeclaration</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getFirstChild</description> 
        
             <lineContent>expression = expression.getFirstChild();</lineContent> 
        
           </mutation>

Explaination

So we have code :-

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/FullIdent.java

Lines 119 to 128 in b8753a7

    
           private static boolean isArrayTypeDeclaration(DetailAST arrayDeclarator) { 
        
               DetailAST expression = arrayDeclarator.getFirstChild(); 
        
               while (expression != null) { 
        
                   if (expression.getType() == TokenTypes.EXPR) { 
        
                       break; 
        
                   } 
        
                   expression = expression.getFirstChild(); 
        
               } 
        
               return expression == null; 
        
           }

in which

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/FullIdent.java

Line 120 in b8753a7

DetailAST expression = arrayDeclarator.getFirstChild();

is mutated as
DetailAST expression = arrayDeclarator

Here expression is assigned as arrayDeclarator.getFirstChild
when the loop is going to start it will check whether the expression is null or not know if we remove .getFirstChild then expression=arrayDeclarator know arrayDeclarator is never going to be null so the loop will always execute, in the loop we have if a condition like expression.getType() == TokenTypes.EXPR which always becomes false because ast is an arrayDeclarator token.
and then at last expression = expression.getFirstChild() hence here is the case why the removal will not affect.
the expression here is again assigned as expression.getFirstChild. so it is not possible a test case in which we can create a test where .getFirstChild() will fail if we assigned it or not it will always execute.

by removal of this effect would the loop run one time more than it was running before.

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/1f89420b96e95d45a945d0f8846d0d0f/raw/ed5ab114bdbdd1359c85db6edf11c4126a0e5965/fullident.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

rdiachenko · 2023-06-07T20:27:24Z

@Kevin222004 please generate a report

Kevin222004 · 2023-06-07T20:32:32Z

@rdiachenko How can i generate report for this change

rdiachenko · 2023-06-07T21:13:02Z

@rdiachenko How can i generate report for this change

Take few checks which use that class and generate report for them.

romani · 2023-06-08T03:35:11Z

Not a class, but affected method.

This class is unfortunate API, so by API rules we do not know it can be used, it just should work in all cases.

romani

Ok to merge as some extra testing is provided

Kevin222004 · 2023-06-08T15:07:02Z

Github, generate report

github-actions · 2023-06-08T17:09:24Z

Regression-1 :
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/37a84ea_2023170815/reports/diff/index.html

Kevin222004 · 2023-06-08T17:19:27Z

Github, generate report

github-actions · 2023-06-08T18:32:53Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/37a84ea_2023183202/reports/diff/index.html

rdiachenko

lgtm

Vyom-Yadav

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/FullIdent.java

Lines 82 to 86 in 3f77dd1

    
           // Here we want type declaration, but not initialization 
        
           final boolean isArrayTypeDeclarationStart = nextSibling != null 
        
                   && (nextSibling.getType() == TokenTypes.ARRAY_DECLARATOR 
        
                       || nextSibling.getType() == TokenTypes.ANNOTATIONS) 
        
                   && isArrayTypeDeclaration(nextSibling);

These lines cover the prior conditions of the ast passed to the method to be non null and not of type EXPR (as if ast is of type EXPR a case exists where if EXPR is passed, it will also break from the loop).

LGTM!

Issue checkstyle#13109: Kill mutation for FullIdent.java

37a84ea

rdiachenko self-assigned this Jun 7, 2023

romani approved these changes Jun 8, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 8, 2023 03:41

rdiachenko approved these changes Jun 8, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 8, 2023

Vyom-Yadav approved these changes Jun 12, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 12, 2023

romani merged commit f23f241 into checkstyle:master Jun 12, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13109: Kill mutation for FullIdent.java#13178

Issue #13109: Kill mutation for FullIdent.java#13178
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:API4

Kevin222004 commented Jun 7, 2023 •

edited

Loading

Uh oh!

rdiachenko commented Jun 7, 2023

Uh oh!

Kevin222004 commented Jun 7, 2023

Uh oh!

rdiachenko commented Jun 7, 2023

Uh oh!

romani commented Jun 8, 2023 •

edited

Loading

Uh oh!

romani left a comment

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

rdiachenko left a comment

Uh oh!

Vyom-Yadav left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>FullIdent.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.api.FullIdent</mutatedClass>
	<mutatedMethod>isArrayTypeDeclaration</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getFirstChild with receiver</description>
	<lineContent>DetailAST expression = arrayDeclarator.getFirstChild();</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>FullIdent.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.api.FullIdent</mutatedClass>
	<mutatedMethod>isArrayTypeDeclaration</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getFirstChild</description>
	<lineContent>expression = expression.getFirstChild();</lineContent>
	</mutation>

	private static boolean isArrayTypeDeclaration(DetailAST arrayDeclarator) {
	DetailAST expression = arrayDeclarator.getFirstChild();
	while (expression != null) {
	if (expression.getType() == TokenTypes.EXPR) {
	break;
	}
	expression = expression.getFirstChild();
	}
	return expression == null;
	}

	// Here we want type declaration, but not initialization
	final boolean isArrayTypeDeclarationStart = nextSibling != null
	&& (nextSibling.getType() == TokenTypes.ARRAY_DECLARATOR
	\|\| nextSibling.getType() == TokenTypes.ANNOTATIONS)
	&& isArrayTypeDeclaration(nextSibling);

Uh oh!

Conversation

Kevin222004 commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutation Covered

Explaination

Uh oh!

rdiachenko commented Jun 7, 2023

Uh oh!

Kevin222004 commented Jun 7, 2023

Uh oh!

rdiachenko commented Jun 7, 2023

Uh oh!

romani commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

Kevin222004 commented Jun 8, 2023

Uh oh!

github-actions bot commented Jun 8, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 7, 2023 •

edited

Loading

romani commented Jun 8, 2023 •

edited

Loading