Skip to content

Issue #13328: Kill mutation for OneStatementPerLineCheck#13163

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:osl1
Jun 29, 2023
Merged

Issue #13328: Kill mutation for OneStatementPerLineCheck#13163
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:osl1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 5, 2023 •
edited
Loading

Issue #13328: Kill mutation for OneStatementPerLineCheck

Check :-

https://checkstyle.org/config_coding.html#OneStatementPerLine

Mutation covered

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 174 to 181 in 6324a9d

<mutation unstable="false">
<sourceFile>OneStatementPerLineCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck</mutatedClass>
<mutatedMethod>beginTree</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable lastStatementEnd</description>
<lineContent>lastStatementEnd = -1;</lineContent>
</mutation>

@romani
Copy link
Copy Markdown
Member

romani commented Jun 6, 2023

You need to provide long explanation why not possible to cover by Inputs.

We do not accept testing by pure unit test.

romani
romani requested changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 21, 2023

@romani done input based test added

@Kevin222004 Kevin222004 force-pushed the osl1 branch 2 times, most recently from 7fea3eb to 580e09b Compare June 22, 2023 07:02
Vyom-Yadav
Vyom-Yadav approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav requested review from rdiachenko and romani June 23, 2023 10:58
@romani romani assigned rdiachenko and unassigned romani Jun 25, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Jun 25, 2023

@Kevin222004 , please resolve conflict and look at CI failing

@Kevin222004 Kevin222004 force-pushed the osl1 branch 2 times, most recently from 2df00bc to 09a54ad Compare June 25, 2023 15:28
romani
romani requested changes Jun 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, last minor.

items:

romani
romani approved these changes Jun 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI is green

@rdiachenko
Copy link
Copy Markdown
Member

rdiachenko commented Jun 28, 2023

@Kevin222004 please resolve a conflict

@Kevin222004 Kevin222004 changed the title Issue #13109: Kill mutation for OneStatementPerLineCheck Issue #13328: Kill mutation for OneStatementPerLineCheck Jun 29, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
12 tasks
rdiachenko
rdiachenko approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned romani and unassigned rdiachenko Jun 29, 2023
@rdiachenko
Copy link
Copy Markdown
Member

rdiachenko commented Jun 29, 2023

rebased via Github

@romani romani merged commit c9876a6 into checkstyle:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav