Skip to content

Issue #13109: Kill mutation for FileText#13157

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:API2
Jun 7, 2023
Merged

Issue #13109: Kill mutation for FileText#13157
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:API2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

Issue #13109: Kill mutation for FileText


Mutation Covered

<mutation unstable="false">
<sourceFile>FileText.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.api.FileText</mutatedClass>
<mutatedMethod>&lt;init&gt;</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable charset</description>
<lineContent>charset = fileText.charset;</lineContent>
</mutation>


Explaination

Test cases added

Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge, ok to pure unit test - it is api

Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jun 5, 2023
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 7, 2023
@romani romani merged commit ae99612 into checkstyle:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants