Skip to content

Issue #13109: Kill mutation for UnusedLocalVariableCheck 6#13149

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ul6
Jun 12, 2023
Merged

Issue #13109: Kill mutation for UnusedLocalVariableCheck 6#13149
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ul6

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 3, 2023 •
edited
Loading

Issue #13109: Kill mutation for UnusedLocalVariableCheck 6

Checks

https://checkstyle.org/config_coding.html#UnusedLocalVariable

Mutation covered

checkstyle/config/pitest-suppressions/pitest-coding-2-suppressions.xml

Lines 309 to 316 in 9580515

<mutation unstable="false">
<sourceFile>UnusedLocalVariableCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.UnusedLocalVariableCheck</mutatedClass>
<mutatedMethod>getBlockContainingLocalAnonInnerClass</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getParent with receiver</description>
<lineContent>DetailAST parentAst = literalNewAst.getParent();</lineContent>
</mutation>

Explaination

hence it is not possible to create a such test that kills mutation. instead of starting the loop with literalNewAst.getParent() if we start from literalnewAst at the end of the first iteration in the loop it will become literalNewAst.getParent. loops run one time more then it was running previously.
hence while as per my changes currentAST go in loop it never be in array of CONTAINERS_FOR_ANON_INNERS

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java

Lines 188 to 194 in 9580515

private static final int[] CONTAINERS_FOR_ANON_INNERS = {
TokenTypes.METHOD_DEF,
TokenTypes.CTOR_DEF,
TokenTypes.STATIC_INIT,
TokenTypes.INSTANCE_INIT,
TokenTypes.COMPACT_CTOR_DEF,
};

because it always be TokenTypes.Literal_NEW. same for if statment in it
currentAST never be TokenTypes.lambda so it will not execute
so removal will not make any effect

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/0dbdfb487f8e9a050ed0e6356f1a35b4/raw/31f7927f400e11e4285e86fd086b373095227848/unusedLocal.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 3, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/61bda84_2023230441/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 8, 2023

Github, generate report

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 8, 2023

NPE in intellij is in existing version
https://gist.githubusercontent.com/Kevin222004/a9aa3fc5da13a160c5388aaad86a6b67/raw/86f5e29cab55050a56264a0e71d19c3ae8d88f7e/gistfile1.txt
issue is for similar kind of code as #13167

@Kevin222004 Kevin222004 marked this pull request as ready for review June 8, 2023 06:36
@Kevin222004 Kevin222004 mentioned this pull request Jun 8, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 8, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/bd0a361_2023071145/reports/diff/index.html

rdiachenko
rdiachenko approved these changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko requested a review from Vyom-Yadav June 8, 2023 20:48
romani
romani approved these changes Jun 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.
Please add this to issue of bad side effects, as example that pitest is heavily against performance improvements, as much improvement is not possible to enforce by test.

@Kevin222004 Kevin222004 mentioned this pull request Jun 11, 2023
Closed
Vyom-Yadav
Vyom-Yadav approved these changes Jun 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 12, 2023
@romani romani merged commit 39fae6b into checkstyle:master Jun 12, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
@Kevin222004 Kevin222004 mentioned this pull request Jan 23, 2024
Closed
@Kevin222004 Kevin222004 mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav