Issue #13109: Kill mutation for ReturnCountCheck by Kevin222004 · Pull Request #13138 · checkstyle/checkstyle

Kevin222004 · 2023-06-02T18:57:43Z

Issue #13109: Kill mutation for ReturnCountCheck

Check :-

https://checkstyle.org/config_coding.html#ReturnCount

Mutation Covered

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 39 to 55 in 655196e

    
           <mutation unstable="false"> 
        
             <sourceFile>ReturnCountCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck</mutatedClass> 
        
             <mutatedMethod>leaveToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/lang/Object::toString</description> 
        
             <lineContent>throw new IllegalStateException(ast.toString());</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>ReturnCountCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck</mutatedClass> 
        
             <mutatedMethod>visitToken</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/lang/Object::toString</description> 
        
             <lineContent>throw new IllegalStateException(ast.toString());</lineContent> 
        
           </mutation>

Explaination

1) Test cases
Here in this check, we have an acceptable token

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheck.java

Lines 332 to 338 in 655196e

    
           public int[] getAcceptableTokens() { 
        
               return new int[] { 
        
                   TokenTypes.CTOR_DEF, 
        
                   TokenTypes.METHOD_DEF, 
        
                   TokenTypes.LAMBDA, 
        
                   TokenTypes.LITERAL_RETURN, 
        
               };

and in visitToken and Leave Token all the acceptable tokens have their own case.
so without pure unit testing not possible to create such kind of scenario to cover default.

2) Removal of code
Here in this check, we have an acceptable token

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheck.java

Lines 332 to 338 in 655196e

    
           public int[] getAcceptableTokens() { 
        
               return new int[] { 
        
                   TokenTypes.CTOR_DEF, 
        
                   TokenTypes.METHOD_DEF, 
        
                   TokenTypes.LAMBDA, 
        
                   TokenTypes.LITERAL_RETURN, 
        
               };

and in visitToken and Leave Token all the acceptable tokens have their own case so Removal of default won't make any issue.
Regression are also clean

Currently applied 1) Test cases

Kevin222004 · 2023-06-03T04:49:17Z

Github, generate report

github-actions · 2023-06-03T06:16:13Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b0bd124_2023061008/reports/diff/index.html

Kevin222004 · 2023-06-03T06:21:40Z

Github, generate report

github-actions · 2023-06-03T08:47:35Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b0bd124_2023084519/reports/diff/index.html

romani

Items

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java

romani

Minors:

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java

romani

.

romani

Ok to merge

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java

rdiachenko

lgtm

Vyom-Yadav

LGTM!

Kevin222004 force-pushed the RC1 branch 2 times, most recently from 47c2eb8 to 1fc218f Compare June 5, 2023 19:50

Kevin222004 marked this pull request as ready for review June 5, 2023 19:50

Kevin222004 force-pushed the RC1 branch from 1fc218f to 713a981 Compare June 5, 2023 19:54

romani requested changes Jun 6, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the RC1 branch from 713a981 to 6f76f4b Compare June 7, 2023 07:04

romani requested changes Jun 7, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java Outdated Show resolved Hide resolved

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java Outdated Show resolved Hide resolved

romani requested changes Jun 7, 2023

View reviewed changes

Kevin222004 mentioned this pull request Jun 7, 2023

Issue #13109: Kill mutation for ReturnCountCheck-2 #13139

Closed

Kevin222004 force-pushed the RC1 branch 2 times, most recently from 7348d09 to 3103243 Compare June 7, 2023 17:57

romani approved these changes Jun 8, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 8, 2023 03:32

romani assigned Vyom-Yadav Jun 8, 2023

rdiachenko requested changes Jun 8, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the RC1 branch from 3103243 to 645073f Compare June 10, 2023 07:50

Issue checkstyle#13109: Kill mutation for ReturnCountCheck

83feeb7

Kevin222004 force-pushed the RC1 branch from 645073f to 83feeb7 Compare June 10, 2023 11:02

rdiachenko approved these changes Jun 10, 2023

View reviewed changes

Vyom-Yadav approved these changes Jun 12, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 12, 2023

romani merged commit 8576b0c into checkstyle:master Jun 12, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13109: Kill mutation for ReturnCountCheck#13138

Issue #13109: Kill mutation for ReturnCountCheck#13138
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:RC1

Kevin222004 commented Jun 2, 2023 •

edited

Loading

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

romani left a comment

Uh oh!

Uh oh!

romani left a comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment •

edited

Loading

Uh oh!

romani left a comment

Uh oh!

Uh oh!

rdiachenko left a comment

Uh oh!

Vyom-Yadav left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>ReturnCountCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck</mutatedClass>
	<mutatedMethod>leaveToken</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/lang/Object::toString</description>
	<lineContent>throw new IllegalStateException(ast.toString());</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>ReturnCountCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck</mutatedClass>
	<mutatedMethod>visitToken</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/lang/Object::toString</description>
	<lineContent>throw new IllegalStateException(ast.toString());</lineContent>
	</mutation>

	public int[] getAcceptableTokens() {
	return new int[] {
	TokenTypes.CTOR_DEF,
	TokenTypes.METHOD_DEF,
	TokenTypes.LAMBDA,
	TokenTypes.LITERAL_RETURN,
	};

Uh oh!

Conversation

Kevin222004 commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check :-

Mutation Covered

Explaination

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 2, 2023 •

edited

Loading

romani left a comment •

edited

Loading