Skip to content

Issue #13109: Kill mutation for UnnecessaryParenthesesCheck 2#13137

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:u2
Jun 7, 2023
Merged

Issue #13109: Kill mutation for UnnecessaryParenthesesCheck 2#13137
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:u2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 2, 2023 •
edited
Loading

Issue #13109: Kill mutation for UnnecessaryParenthesesCheck 2

check :- https://checkstyle.org/config_coding.html#UnnecessaryParentheses

Mutation covered

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 66 to 73 in 655196e

<mutation unstable="false">
<sourceFile>UnnecessaryParenthesesCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck</mutatedClass>
<mutatedMethod>visitToken</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getText</description>
<lineContent>log(ast, MSG_LAMBDA, ast.getText());</lineContent>
</mutation>

Explaination

ast.gettext() is not require because we are not showing it.

checkstyle/src/main/resources/com/puppycrawl/tools/checkstyle/checks/coding/messages.properties

Line 60 in 655196e

unnecessary.paren.lambda=Unnecessary parentheses around lambda value.

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 3, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2023

Project list 1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ef70770_2023055805/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 3, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2023

Project list 2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ef70770_2023084250/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review June 5, 2023 17:53
romani
romani approved these changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch by pitest

@romani romani requested review from Vyom-Yadav and rdiachenko June 6, 2023 02:18
rdiachenko
rdiachenko approved these changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Vyom-Yadav
Vyom-Yadav approved these changes Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Jun 7, 2023
@romani romani merged commit 63cd22d into checkstyle:master Jun 7, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav