Issue #13109: Kill mutation for UnnecessaryParenthesesCheck#13136
Merged
romani merged 1 commit intocheckstyle:masterfrom Jun 13, 2023
Merged
Issue #13109: Kill mutation for UnnecessaryParenthesesCheck#13136romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
Github, generate report |
Contributor
Contributor
Author
|
Github, generate report |
Contributor
1249c62 to
94b6da1
Compare
romani
approved these changes
Jun 10, 2023
Member
romani
left a comment
There was a problem hiding this comment.
Ok to merge.
We do not use null state of this field.
Member
|
@Kevin222004 Please resolve the conflicts. |
Contributor
Author
|
@Vyom-Yadav done |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13109: Kill mutation for UnnecessaryParenthesesCheck
Check :-
https://checkstyle.org/config_coding.html#UnnecessaryParentheses
mutation
checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml
Lines 48 to 55 in c5566a6
Explaination
The only reason i can see to removal of this will not make issue is the checkExpression method is used only in leaveToken
so the changes of ParentToSkip will not really make any effect in code because token will be leaved if the is statment is been executed, it will never be used after it.
Regression :-
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/13cdd33_2023060542/reports/diff/index.html
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/13cdd33_2023085740/reports/diff/index.html