Issue #13328: Kill mutation for EqualsAvoidNullCheck 4 by Kevin222004 · Pull Request #13127 · checkstyle/checkstyle

Kevin222004 · 2023-06-01T07:35:13Z

Issue #13328: Kill mutation for EqualsAvoidNullCheck 4

covering

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 39 to 46 in 81448ea

    
           <mutation unstable="false"> 
        
             <sourceFile>EqualsAvoidNullCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck$FieldFrame</mutatedClass> 
        
             <mutatedMethod>getMethodCalls</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to java/util/Collections::unmodifiableSet with argument</description> 
        
             <lineContent>return Collections.unmodifiableSet(methodCalls);</lineContent> 
        
           </mutation>

Kevin222004 · 2023-06-01T07:35:42Z

GitHub, generate report

github-actions · 2023-06-01T11:15:11Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/09c5d1c_2023111250/reports/diff/index.html

romani

items:

src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java

romani

Items:

romani · 2023-06-06T02:21:32Z

pom.xml

                <param>com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanReturnCheckTest</param>
              </targetTests>
+              <avoidCallsTo>
+                <avoidCallsTo>java.util.Collections</avoidCallsTo>


This is too broad exclusion.
Can we narrow to Collections.unmodifiableSet ?

If there is no way , please prove it .

Absolutely last resort: we can wrap such method in checkstyle util method and exclude by our class.

Can we narrow to Collections.unmodifiableSet ?

no

If there is no way , please prove it .

the documentation says that https://pitest.org/quickstart/maven/#:~:text=List%20of%20packages%20and%20classes%20which%20are%20to%20be%20considered%20outside%20the%20scope%20of%20mutation.%20Any%20lines%20of%20code%20containing%20calls%20to%20these%20classes%20will%20not%20be%20mutated. classes will not mutate hence it is not mentioned about a particular method anywhere.
Apart of this i have report only https://kevin222004.github.io/Regression/com.puppycrawl.tools.checkstyle.checks.coding/EqualsAvoidNullCheck.java.html

Absolutely last resort: we can wrap such method in checkstyle util method and exclude by our class.

I am not getting you on this, if we will create and call such kind of method we have to pass the parameter and hence it is not making any difference right know with Collections.unmodifiableSet so it will also not make any impact withour new mwthod as well it will again a pit failure as a argument propagation one

Create class in our project with name UnmodifableCollectionUtil
Make method

unmodifiableSet(collection){ return Collections.unmodifiableSet(collection); }

Add javadoc to this class to explain reason of wrapping of jdk method.
Add our class to pitest config for no mutation.

Please ALWAYS share links to what is done.

Share a link please

Actually I have posted on mailing list which is not public if they reply then it will visible but i will share on their issue by today

That is why better to open ticket on GitHub. In worse case they will close it won't fix. It gives all others from world to participate and support idea

That is why better to open ticket on GitHub. In worse case they will close it won't fix. It gives all others from world to participate and support idea

Yes, from next time will take care of this

I have opened an issue hcoles/pitest#1233

romani

Items:

src/main/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtil.java

romani

Items:

src/test/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtilTest.java

romani · 2023-06-17T21:26:21Z

There is conflict, and waiting for input test

Kevin222004 · 2023-06-18T05:57:45Z

There is conflict, and waiting for input test

To be honest I have given a time to create a input based test but I really don't find anything so i have leaved as it is.
all though to me as well this is on top priority to complete the whole coding-1 profile.

I will give once again time and try to find something

Kevin222004 · 2023-06-18T11:38:18Z

@romani please start reviewing other pull request they are ready ci failures are not related to changes

Kevin222004 · 2023-06-18T13:22:42Z

@romani if you don't have any issue can I Suppress the UnmodifableCollectionUtil class from the util profile as well.
code we can cover code coverage with input but to kill this (return Collections.unmodifiableSet(collection); here this is mutated as collection )mutation with input is difficult

romani · 2023-06-19T00:13:23Z

Please resolve conflict

Kevin222004 · 2023-06-19T09:36:33Z

@romani I have updated the branch with input based testing but i have suppress our new class from util profile

romani

items:

src/test/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtilTest.java

romani · 2023-06-28T03:47:52Z

I still don't see answers to my questions.

romani

Items

pom.xml

romani

Ok to merge

romani · 2023-06-30T12:57:25Z

@Kevin222004 , please update linkcheck suppression file.

Vyom-Yadav

LGTM!

rdiachenko

lgtm

Kevin222004 marked this pull request as draft June 2, 2023 05:01

Kevin222004 force-pushed the EV4 branch from 09c5d1c to a783f78 Compare June 2, 2023 12:50

Kevin222004 marked this pull request as ready for review June 2, 2023 12:55

romani requested changes Jun 2, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java Outdated Show resolved Hide resolved

Kevin222004 mentioned this pull request Jun 3, 2023

Bad Side effects of Pitest #13142

Closed

Kevin222004 force-pushed the EV4 branch from a783f78 to 6b1929f Compare June 5, 2023 16:26

romani requested changes Jun 6, 2023

View reviewed changes

Kevin222004 force-pushed the EV4 branch from 6b1929f to 403a20e Compare June 13, 2023 06:55

Kevin222004 mentioned this pull request Jun 13, 2023

Issue #13109: Kill mutation for EqualsAvoidNullCheck 3 #13126

Closed

Kevin222004 force-pushed the EV4 branch 2 times, most recently from 90fdba2 to db22771 Compare June 13, 2023 07:53

romani requested changes Jun 13, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtil.java Outdated Show resolved Hide resolved

src/main/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtil.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the EV4 branch from db22771 to 678566b Compare June 13, 2023 17:41

romani requested changes Jun 13, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtilTest.java Outdated Show resolved Hide resolved

Kevin222004 mentioned this pull request Jun 18, 2023

Allowing 'avoidCallsTo' to Suppress Specific Methods Instead of Entire Classes" hcoles/pitest#1233

Open

Kevin222004 force-pushed the EV4 branch 2 times, most recently from 1e6340f to 15f39c6 Compare June 19, 2023 09:34

romani requested changes Jun 19, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtilTest.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the EV4 branch 4 times, most recently from 25c6765 to 6d7aa1e Compare June 21, 2023 07:49

Kevin222004 force-pushed the EV4 branch 4 times, most recently from d061dd2 to 0d1907c Compare June 26, 2023 15:34

romani self-assigned this Jun 27, 2023

Kevin222004 force-pushed the EV4 branch 3 times, most recently from d68eff0 to 523b263 Compare June 28, 2023 15:28

romani requested changes Jun 28, 2023

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Kevin222004 mentioned this pull request Jun 30, 2023

Targeted Pitest Mutation in July 2023 #13328

Closed

12 tasks

Kevin222004 changed the title ~~Issue #13109: Kill mutation for EqualsAvoidNullCheck 4~~ Issue #13328: Kill mutation for EqualsAvoidNullCheck 4 Jun 30, 2023

Kevin222004 force-pushed the EV4 branch from 523b263 to ba51ca4 Compare June 30, 2023 05:41

romani approved these changes Jun 30, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 30, 2023 12:57

romani assigned Vyom-Yadav and unassigned romani Jun 30, 2023

Kevin222004 force-pushed the EV4 branch from ba51ca4 to 6fb7931 Compare June 30, 2023 18:15

Issue checkstyle#13328: Kill mutation for EqualsAvoidNullCheck 4

a31545b

Kevin222004 force-pushed the EV4 branch from 6fb7931 to a31545b Compare June 30, 2023 18:25

Vyom-Yadav approved these changes Jul 2, 2023

View reviewed changes

Vyom-Yadav assigned rdiachenko and unassigned Vyom-Yadav Jul 2, 2023

rdiachenko approved these changes Jul 3, 2023

View reviewed changes

rdiachenko merged commit bd19c44 into checkstyle:master Jul 3, 2023

romani mentioned this pull request Jul 14, 2023

Issue #13321: Kill mutation for DetailAstImpl #13387

Merged

Kevin222004 mentioned this pull request Jan 23, 2024

Bad side effects of Pitest hcoles/pitest#1294

Closed

Kevin222004 mentioned this pull request Jan 30, 2024

creation of mutable collection consider as can be avoided hcoles/pitest#1300

Open

	<mutation unstable="false">
	<sourceFile>EqualsAvoidNullCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck$FieldFrame</mutatedClass>
	<mutatedMethod>getMethodCalls</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to java/util/Collections::unmodifiableSet with argument</description>
	<lineContent>return Collections.unmodifiableSet(methodCalls);</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kevin222004 commented Jun 1, 2023

Uh oh!

github-actions bot commented Jun 1, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani commented Jun 17, 2023

Uh oh!

Kevin222004 commented Jun 18, 2023

Uh oh!

Kevin222004 commented Jun 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kevin222004 commented Jun 18, 2023

Uh oh!

romani commented Jun 19, 2023

Uh oh!

Kevin222004 commented Jun 19, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani commented Jun 28, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani commented Jun 30, 2023

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Kevin222004 commented Jun 1, 2023 •

edited

Loading

Kevin222004 commented Jun 18, 2023 •

edited

Loading