Issue #13109: Kill mutation for EqualsAvoidNullCheck 2 by Kevin222004 · Pull Request #13125 · checkstyle/checkstyle

Kevin222004 · 2023-06-01T07:09:55Z

Issue #13109: Kill mutation for EqualsAvoidNullCheck 2

1 check :- https://checkstyle.org/config_coding.html#EqualsAvoidNull

2covering :-

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 21 to 28 in 81448ea

    
           <mutation unstable="false"> 
        
             <sourceFile>EqualsAvoidNullCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck</mutatedClass> 
        
             <mutatedMethod>isStringFieldOrVariableFromClass</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck::getObjectFrame with argument</description> 
        
             <lineContent>frame = getObjectFrame(frame.getParent());</lineContent> 
        
           </mutation>

3 Explaination
getObjectFrame() method will provide the nearest parent frame of class, enum.

if we remove getObjectFramefrom the FieldFrame frame = getObjectFrame(currentFrame); and frame = getObjectFrame(frame.getParent()); they will go through all the frame instead of directly going to frame which are class or enum.

and as per the condition in loop className.equals(frame.getFrameName())
frameName would always be of class enum as per

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java

Lines 568 to 569 in 81448ea

    
           /** Name of the class, enum or enum constant declaration. */ 
        
           private String frameName;

so removal of that not make any issue

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c201250_2023104332/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/c515fe44cd311783e6cbdf0f5788b4d3/raw/15647eeebde66f0c3a366f655442b02b4d55efef/equal.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Project-list-2

Kevin222004 · 2023-06-01T07:11:52Z

GitHub, generate report

github-actions · 2023-06-01T10:45:53Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c201250_2023104332/reports/diff/index.html

romani

ok to merge.

rdiachenko · 2023-06-02T19:16:23Z

@Kevin222004 please resolve the conflict and regenerate report

Kevin222004 · 2023-06-03T11:30:59Z

Github, generate report

github-actions · 2023-06-03T12:39:45Z

Project-list-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f189e54_2023123901/reports/diff/index.html

Kevin222004 · 2023-06-03T12:42:25Z

Github, generate report

github-actions · 2023-06-03T14:37:01Z

Project-list-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f189e54_2023143550/reports/diff/index.html

Kevin222004 · 2023-06-03T15:58:42Z

@rdiachenko reports are clean

Vyom-Yadav · 2023-06-04T03:52:12Z

Issue #13109: Kill mutation for EqualsAvoidNullCheck 2

Check :- https://checkstyle.org/config_coding.html#EqualsAvoidNull

Mutations Covered

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 21 to 28 in 81448ea

    
           <mutation unstable="false"> 
        
             <sourceFile>EqualsAvoidNullCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck</mutatedClass> 
        
             <mutatedMethod>isStringFieldOrVariableFromClass</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck::getObjectFrame with argument</description> 
        
             <lineContent>frame = getObjectFrame(frame.getParent());</lineContent> 
        
           </mutation>

Explanation

getObjectFrame() method will provide the nearest parent frame of class, enum.

if we remove getObjectFramefrom the FieldFrame frame = getObjectFrame(currentFrame); and frame = getObjectFrame(frame.getParent()); they will go through all the frame instead of directly going to frame which are class or enum.

and as per the condition in loop className.equals(frame.getFrameName()) frameName would always be of class enum as per

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java

Lines 568 to 569 in 81448ea

    
           /** Name of the class, enum or enum constant declaration. */ 
        
           private String frameName;

so removal of that not make any issue

Diff Reports

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c201250_2023104332/reports/diff/index.html

Config (You can remove this after you have generated the reports)

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/c515fe44cd311783e6cbdf0f5788b4d3/raw/15647eeebde66f0c3a366f655442b02b4d55efef/equal.xml Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties Report label: Project-list-2

@Kevin222004 slight improvement in formatting makes it look better, you can use --- instead of numbers, it looks cleaner.

Vyom-Yadav

LGTM!

rdiachenko

lgtm

Kevin222004 marked this pull request as draft June 2, 2023 05:02

Kevin222004 force-pushed the EV2 branch from c201250 to 1b2b0f1 Compare June 2, 2023 06:39

Kevin222004 marked this pull request as ready for review June 2, 2023 06:45

Kevin222004 force-pushed the EV2 branch from 1b2b0f1 to 1bbbf78 Compare June 2, 2023 07:34

romani approved these changes Jun 2, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko June 2, 2023 13:30

Issue checkstyle#13109: Kill mutation for EqualsAvoidNullCheck 2

f189e54

Kevin222004 force-pushed the EV2 branch from 1bbbf78 to f189e54 Compare June 3, 2023 05:49

Vyom-Yadav approved these changes Jun 4, 2023

View reviewed changes

rdiachenko approved these changes Jun 4, 2023

View reviewed changes

rdiachenko merged commit 655196e into checkstyle:master Jun 4, 2023

Kevin222004 mentioned this pull request Jun 29, 2023

Resolve pitest survivals in modules #13109

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13109: Kill mutation for EqualsAvoidNullCheck 2#13125

Issue #13109: Kill mutation for EqualsAvoidNullCheck 2#13125
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:EV2

Kevin222004 commented Jun 1, 2023 •

edited

Loading

Uh oh!

Kevin222004 commented Jun 1, 2023

Uh oh!

github-actions bot commented Jun 1, 2023

Uh oh!

romani left a comment

Uh oh!

rdiachenko commented Jun 2, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

Vyom-Yadav commented Jun 4, 2023

Uh oh!

Vyom-Yadav left a comment

Uh oh!

rdiachenko left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>EqualsAvoidNullCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck</mutatedClass>
	<mutatedMethod>isStringFieldOrVariableFromClass</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck::getObjectFrame with argument</description>
	<lineContent>frame = getObjectFrame(frame.getParent());</lineContent>
	</mutation>

	/** Name of the class, enum or enum constant declaration. */
	private String frameName;

Uh oh!

Conversation

Kevin222004 commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kevin222004 commented Jun 1, 2023

Uh oh!

github-actions bot commented Jun 1, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko commented Jun 2, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

github-actions bot commented Jun 3, 2023

Uh oh!

Kevin222004 commented Jun 3, 2023

Uh oh!

Vyom-Yadav commented Jun 4, 2023

Check :- https://checkstyle.org/config_coding.html#EqualsAvoidNull

Mutations Covered

Explanation

Diff Reports

Config (You can remove this after you have generated the reports)

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jun 1, 2023 •

edited

Loading