Issue #13109: Kill mutation for EqualsAvoidNullCheck#13124
Merged
rdiachenko merged 1 commit intocheckstyle:masterfrom Jun 2, 2023
Merged
Issue #13109: Kill mutation for EqualsAvoidNullCheck#13124rdiachenko merged 1 commit intocheckstyle:masterfrom
rdiachenko merged 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
GitHub, generate report |
Contributor
|
Report generation failed on phase "parse_body", |
Contributor
Author
|
GitHub, generate report |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13109: Kill mutation for EqualsAvoidNullCheck
1 check :- https://checkstyle.org/config_coding.html#EqualsAvoidNull
2covering :-
checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml
Lines 12 to 19 in 81448ea
3 Explaination
getObjectFrame()method will provide the nearest parent frame of class, enum.if we remove getObjectFramefrom the
FieldFrame frame = getObjectFrame(currentFrame);andframe = getObjectFrame(frame.getParent());they will go through all the frame instead of directly going to frame which are class or enum.and as per the condition in loop
className.equals(frame.getFrameName())frameName would always be of class enum as per
checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java
Lines 568 to 569 in 81448ea
so removal of that not make any issue
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b863d4b_2023095222/reports/diff/index.html