Skip to content

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 6#13122

Merged
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:M7
Jun 2, 2023
Merged

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 6#13122
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:M7

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jun 1, 2023 •
edited
Loading

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 6

covering

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 111 to 118 in 81448ea

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>isVariableInOperatorExpr</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling with receiver</description>
<lineContent>DetailAST exprBetweenBrackets = openingBracket.getNextSibling();</lineContent>
</mutation>

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 1, 2023

GitHub, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2023

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4b71bc8_2023091358/reports/diff/index.html

@Kevin222004 Kevin222004 force-pushed the M7 branch 2 times, most recently from d8925d9 to af62c8c Compare June 1, 2023 19:50
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jun 1, 2023

@rdiachenko please review this as well

romani
romani approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as where is no regression - lets remove.

rdiachenko
rdiachenko approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit e67d981 into checkstyle:master Jun 2, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Jun 2, 2023

@rdiachenko , let's keep @Vyom-Yadav as mandatory reviewer, he has big exposure to pitest fixes before.
As we balance our knowledge and level of quality and consideration between us, we can probably skip all-mrentors reviews.
But for first few weeks let's use 3 review.

@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

@Vyom-Yadav Vyom-Yadav Awaiting requested review from Vyom-Yadav

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kevin222004 @romani @rdiachenko