Skip to content

Issue #13108: Resolves Pitest for AbstractSuperCheck#13111

Merged
nrmancuso merged 1 commit intocheckstyle:masterfrom
Kevin222004:ASC1
May 31, 2023
Merged

Issue #13108: Resolves Pitest for AbstractSuperCheck#13111
nrmancuso merged 1 commit intocheckstyle:masterfrom
Kevin222004:ASC1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented May 30, 2023

Issue #13108: Resolves Pitest for AbstractSuperCheck

covering

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 3 to 11 in f633d9b

<mutation unstable="false">
<sourceFile>AbstractSuperCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.AbstractSuperCheck$MethodNode</mutatedClass>
<mutatedMethod>&lt;init&gt;</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable callingSuper</description>
<lineContent>callingSuper = false;</lineContent>
</mutation>

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 30, 2023

Test cases not found.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/AbstractSuperCheck.java

Lines 215 to 217 in f633d9b

private MethodNode(DetailAST ast) {
method = ast;
callingSuper = false;

In the constructor only the parameter ast is taken for private final DetailAST method; every time when the object of MethodNode class is created then private boolean callingSuper; is been set false by the constructor intially.

By default in java the value of none initalize boolean variable is false;
https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html#:~:text=boolean-,false,-Local%20variables%20are
so if it is been removed it not make any changes.

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 30, 2023 •
edited
Loading

This might not be a good practice to leave a variable on default initialization and not initialize it by ourselves.
There are lots of mutations similar to this.

@romani @Vyom-Yadav @rdiachenko do you have any suggestions for this type of case?

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 30, 2023

Regression :-
https://kevin222004.github.io/RegressionReport/

https://kevin222004.github.io/Regression-r1/

@rdiachenko
Copy link
Copy Markdown
Member

rdiachenko commented May 30, 2023

This might not be a good practice to leave a variable on default initialization and not initialize it by ourselves. There are lots of mutations similar to this.

@romani @Vyom-Yadav @rdiachenko do you have any suggestions for this type of case?

If it's a primitive type like boolean I don't see why we shouldn't rely on default initialization. If you check other checks we do rely on default false for boolean properties.

rdiachenko
rdiachenko approved these changes May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

nrmancuso
nrmancuso suggested changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevin222004 different SHA of patch branch in reports and PR is questionable; if we are removing code, regression reports should be generated on final SHA of the commit in your PR.

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 31, 2023 •
edited
Loading

@nrmancuso I am also not sure how this happens, I will generate it again.

Vyom-Yadav
Vyom-Yadav approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romani romani assigned nrmancuso and unassigned Vyom-Yadav May 31, 2023
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 31, 2023

@nrmancuso
new report :- https://kevin222004.github.io/reports/ASC1/2023-05-31-T-13-58-32/test-report/index.html

romani
romani approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@nrmancuso nrmancuso merged commit 6823f21 into checkstyle:master May 31, 2023
@nrmancuso nrmancuso mentioned this pull request May 31, 2023
Closed
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+2 more reviewers

@nrmancuso nrmancuso nrmancuso approved these changes

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nrmancuso nrmancuso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kevin222004 @rdiachenko @romani @nrmancuso @Vyom-Yadav