Skip to content

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 2#13098

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:M2
May 29, 2023
Merged

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 2#13098
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:M2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented May 29, 2023

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 2

Covering

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 147 to 154 in 6f451fb

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>isInitializationSequence</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getText</description>
<lineContent>.findFirstToken(TokenTypes.IDENT).getText();</lineContent>
</mutation>

and

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 156 to 163 in 6f451fb

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>isInitializationSequence</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::findFirstToken with receiver</description>
<lineContent>.findFirstToken(TokenTypes.IDENT).getText();</lineContent>
</mutation>

and

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 165 to 172 in 6f451fb

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>isInitializationSequence</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/String::equals</description>
<lineContent>isUsedVariableDeclarationFound = variableName.equals(currentVariableName);</lineContent>
</mutation>

romani
romani approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

@rdiachenko , @Vyom-Yadav , lets have agreement that if PR is just removal of survivals and test extension, then single review is enough from any of us.

@romani romani merged commit d7f62fc into checkstyle:master May 29, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani