Skip to content

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 1#13096

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:M1
May 29, 2023
Merged

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 1#13096
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:M1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented May 29, 2023 •
edited
Loading

Issue #13095: kill mutation for VariableDeclarationUsageDistanceCheck 1

covering

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 120 to 127 in 6f451fb

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>calculateDistanceBetweenScopes</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_4</mutator>
<description>RemoveSwitch 4 (case value 85)</description>
<lineContent>switch (blockWithVariableUsage.getType()) {</lineContent>
</mutation>

and

checkstyle/config/pitest-suppressions/pitest-coding-1-suppressions.xml

Lines 138 to 145 in 6f451fb

<mutation unstable="false">
<sourceFile>VariableDeclarationUsageDistanceCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck</mutatedClass>
<mutatedMethod>getDistToVariableUsageInChildNode</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_6</mutator>
<description>RemoveSwitch 6 (case value 91)</description>
<lineContent>switch (examineNode.getType()) {</lineContent>
</mutation>

@romani
Copy link
Copy Markdown
Member

romani commented May 29, 2023

@Kevin222004 , there is conflict.

romani
romani approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge after CI pass

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented May 29, 2023

@romani CI green please merge it, so that #13099 this will also be green

@romani romani merged commit 6a587f9 into checkstyle:master May 29, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jun 29, 2023
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani