dependency: bump sb-contrib from 7.4.7 to 7.6.0#12855
Merged
nrmancuso merged 1 commit intoJul 4, 2023
Merged
Conversation
Contributor
|
Member
I donot understand this violation
ok, may be
I am not sure we should follow name of collection: |
Contributor
|
For the first one, I think it is supposed to be on line 487: I think it is fine to rename all |
Member
'deques' is weird word for me, it was always a problem for me to keep in mind that in whole world stack is stack, but in Java it is deque. It is too technical. Name of variable should be content focused and user friendly. |
0a00aeb to
127b84f
Compare
Member
|
resolving violations is postponed until #13351 we might get some help from outside of team to fix it. |
127b84f to
7f00584
Compare
7f00584 to
c5ac064
Compare
Bumps [sb-contrib](https://github.com/mebigfatguy/fb-contrib) from 7.4.7 to 7.6.0. - [Release notes](https://github.com/mebigfatguy/fb-contrib/releases) - [Commits](mebigfatguy/fb-contrib@v7.4.7...v7.6.0) --- updated-dependencies: - dependency-name: com.mebigfatguy.sb-contrib:sb-contrib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c5ac064 to
ac288d3
Compare
nrmancuso
approved these changes
Jul 4, 2023
Contributor
|
Failure in CI is not related to changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sb-contrib from 7.4.7 to 7.6.0.
Commits
a664c28chore: prepare the 7.6.0 releasec6d811dformatting0b08389add insert as a risky name8eacac9add more modifying methods1fc9e00guard against calls from a subclass of ToStringBuilder882ff86add stream as a risky name for PRMC810af2dcomputeIfAbsent to modifying methods7227f86add sstack/deque to CollectionNameConfusion, and avoid 'offset'bdb9ca0add CyclicBarrier.await to MDM sample testb194c6bfix up optional.equals checkYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)