Issue #11163: Enforced file size on inputs#11177
Conversation
e1b1edc to
eb7f8e0
Compare
5f48fce to
411be70
Compare
411be70 to
15a2f70
Compare
d5ea21c to
219bfa9
Compare
| <suppress checks="FileLength" | ||
| files="[\\/]expectedUppercaseInPackageNameAst\.txt"/> | ||
| <suppress checks="FileLength" | ||
| files="[\\/]expectedSpaceBeforeDescriptionInBlockJavadocTagsAst\.txt"/> |
There was a problem hiding this comment.
I would think we would not make violations on expected files. It is direct output of the input after going through the Checkstyle process. If the input file is flagged to be trimmed, then it will already affect the expected file. But if we are flagging only the expected file, then it may need extra scrutiny if we can even fix the issue.
@romani ping
There was a problem hiding this comment.
If the input file is flagged to be trimmed, then it will already affect the expected file.
I think that we would have to suppress expected files irrespective of whether the input file for the Checkstyle process is trimmed or not. The input file can be within the limit but the printed AST can exceed the length of 120.
Example -
https://github.com/checkstyle/checkstyle/blob/master/src/test/resources/com/puppycrawl/tools/checkstyle/asttreestringprinter/ExpectedAstTreeStringPrinterFullOfSinglelineComments.txt
The input file is under the limit but the output file is not.
There was a problem hiding this comment.
It depends on the type of output, but it may be a possibility we can trim the input file more so the output is within the size too. This is why I pinged @romani to confirm.
There was a problem hiding this comment.
Yes, we need to exclude txt files, we need to validate only java files.
There was a problem hiding this comment.
There was a problem hiding this comment.
We can use fileExtensions property of FileLengthCheck to specify java files only until #11178
There was a problem hiding this comment.
27b5d56 to
263a1b9
Compare
a5474a5 to
a892269
Compare
This does not resolve the issue since all suppressions are tied to this issue. |
Resolves #11163: enforce file size on inputs