Skip to content

minor: test openjdk10 repo#10911

Closed
nrmancuso wants to merge 1 commit into
checkstyle:masterfrom
nrmancuso:try-openjdk-10
Closed

minor: test openjdk10 repo#10911
nrmancuso wants to merge 1 commit into
checkstyle:masterfrom
nrmancuso:try-openjdk-10

Conversation

@nrmancuso

Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation job failed on phase "parse_body", step "React with rocket on run".
Link: https://github.com/checkstyle/checkstyle/actions/runs/1395829817

@github-actions

Copy link
Copy Markdown
Contributor

Report generation job failed on phase "make_report", step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/1395835851

@nrmancuso

Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation job failed on phase "make_report", step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/1395981405

@rnveach

rnveach commented Oct 30, 2021

Copy link
Copy Markdown
Contributor
Exception in thread "main" java.lang.Error: Error was thrown while processing /home/runner/work/checkstyle/checkstyle/contribution/checkstyle-tester/src/main/java/openjdk10/test/hotspot/jtreg/gc/TestBigObj.java
...
Caused by: java.lang.OutOfMemoryError: Java heap space

@nrmancuso

nrmancuso commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

Yes, this is being caused by OOM in FileText#readFile:

Caused by: java.lang.OutOfMemoryError: Java heap space
	at java.base/java.util.Arrays.copyOf(Arrays.java:3745)
	at java.base/java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:172)
	at java.base/java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:686)
	at java.base/java.lang.StringBuilder.append(StringBuilder.java:228)
	at com.puppycrawl.tools.checkstyle.api.FileText.readFile(FileText.java:211)
	at com.puppycrawl.tools.checkstyle.api.FileText.<init>(FileText.java:170)
	at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:326)
	at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:289)
	at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:221)

I have been trying to reproduce this locally, but no luck yet. For what it's worth, this file is gigantic (it crashes intellij for me locally):

➜  gc git:(dev) cat TestBigObj.java | wc -l
65588

@rnveach

rnveach commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Yea, sometimes CI has lower memory than usual. I would say put the file to the ignore list if it can't be made stable.

@nrmancuso

Copy link
Copy Markdown
Contributor Author

I would say put the file to the ignore list if it can't be made stable.

We currently ignore the exclusion list in the projects file for diff report generation, this would require enabling excludes via the --allowExcludes option.

@rnveach

rnveach commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Sorry, I forgot. So we are still blocked from using openjdk10?

@nrmancuso

Copy link
Copy Markdown
Contributor Author

So we are still blocked from using openjdk10?

From this issue in FileText now, yes. I wanted to do more investigation before creating an issue or commenting in checkstyle/contribution#527 (comment) .

@romani

romani commented Dec 4, 2021

Copy link
Copy Markdown
Member

GitHub, rebase

@romani

romani commented Dec 4, 2021

Copy link
Copy Markdown
Member

Github, generate report

@github-actions

github-actions Bot commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

Report generation job failed on phase "make_report", step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/1539925131

@romani

romani commented Dec 5, 2021

Copy link
Copy Markdown
Member

Report is failed:
Caused by: java.lang.OutOfMemoryError: Java heap space

@romani

romani commented Dec 5, 2021

Copy link
Copy Markdown
Member

CI execution is limited by memory, it is fine, as we know 9.x is excessive on memory, until it is fixed, no reason even try.

Let's move this report/config to PR where @nmancus1 try to fix memory usage.

@nrmancuso

Copy link
Copy Markdown
Contributor Author

Let's move this report/config to PR where @nmancus1 try to fix memory usage.

Done, I am closing this.

@nrmancuso nrmancuso closed this Dec 5, 2021
@nrmancuso nrmancuso deleted the try-openjdk-10 branch December 5, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants