🦢
without this its no fun, leaking all the error to prod.

We have no leaks, execution is wrapped by groovy to handle errors

command is locally not working

please run locally and show me output:

./mvnw -e --no-transfer-progress clean compile -P error-prone-compile

we dont see errors because they not fail on error.

We have no leaks, execution is wrapped by groovy to handle errors

this the leckage:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/circleci/project/src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java:[651,23] [NullArgumentForNonNullParameter] Null is not permitted for this parameter.
(see https://errorprone.info/bugpattern/NullArgumentForNonNullParameter)
[ERROR] /home/circleci/project/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilTest.java:[294,32] [NullArgumentForNonNullParameter] Null is not permitted for this parameter.
(see https://errorprone.info/bugpattern/NullArgumentForNonNullParameter)
[INFO] 2 errors
[INFO] -------------------------------------------------------------

This how CI is not leaking anything

Execution without groovy is for users on local to reproduce validation.

This is required, because error prone did not have reports, so we have to parse output, brutal, but works. Root reason is no report that we can parse after execution.
It will allow us to fail on error and get all violations

we dont need violations, we need need just to fail bbuild like. in rewrite pmd spotbugs or spotless. we just nneed stability and no extra extra.

Extra script helped us to fix all violations gradually, it will stay, even we are at 0 violations level.
It can help at #18599 to enable all to errors by single PR, to resolve later existing problems, but new problems will not be leaked

This has not been the first time you brought this up in this repository @Pankraz76.

@romani and team have Error Prone setup with a Groovy script as he mentions. That's how they prefer it, so that's how it'll be. So no need to change anything about it 😄.

@rickie , if there will be some native approach for external config suppression, it would be awesome and we can remove extra groovy wrapper.

Fixing old problems might take some time, but we would like to freeze all old problems and not let new problem to popup on new rules.

thats kind of a flex we could have this for rewrite as well and spotless.

• Pull #18610: Align rewrite readme batch #18589 #18610

pmd also missing here but its broken anyways so thats something else.