Skip to content

Complitaion jobs in CircleCI do not pick up all files #18092

@stoyanK7

Description

@stoyanK7

Noticed in CircleCI job https://app.circleci.com/pipelines/github/checkstyle/checkstyle/37771/workflows/847554ee-ec79-474b-acc5-284bd4a6e9f5/jobs/1128669?invite=true#step-102-4729_26

...
No Java22 files to process

This is not true, because we have multiple files that are marked as compilable with JavaX

Image

The issue comes from the grep here:

javac22)
files=($(grep -Rl --include='*.java' ': Compilable with Java22' \
src/test/resources-noncompilable \
src/it/resources-noncompilable \
src/xdocs-examples/resources-noncompilable || true))

It is not case-insensitive, and therefore does not pick up these files:

grep -Rl --include='*.java' ': Compilable with Java22' \
        src/test/resources-noncompilable \
        src/it/resources-noncompilable \
        src/xdocs-examples/resources-noncompilable

# no output

We need to add -i/--ignore-case to make it pick up these files:

grep -Rli --include='*.java' ': Compilable with Java22' \
        src/test/resources-noncompilable \
        src/it/resources-noncompilable \
        src/xdocs-examples/resources-noncompilable

src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternsInIfStatement.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternsInSwitch.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionCaseDefault.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternsInFor.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternMatchingInSwitch.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternsInTernary.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionPatternsInWhile.java
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/missingswitchdefault/InputMissingSwitchDefaultCaseLabelElements.java

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions