As soon as all violation of special type are resolved , mark them as ERROR in pom.xml to avoid happening again.
[INFO] --- compiler:3.14.1:testCompile (error-prone-test-compile) @ checkstyle ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 823 source files with javac [debug release 17] to target/test-classes
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/bdd/TestInputViolation.java:[88,20]
[EqualsGetClass] Prefer instanceof to getClass when implementing Object#equals.
(see https://errorprone.info/bugpattern/EqualsGetClass)
Did you mean 'return object instanceof TestInputViolation && compareTo((TestInputViolation) object) == 0;'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[185,57]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean 'return (indentInComment >= expectedMinimalIndent && !isWarnComment)'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[186,60]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean '|| (indentInComment < expectedMinimalIndent && isWarnComment);'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[203,49]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean 'return (expectedLevel == indentInComment && !isWarnComment)'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[204,53]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean '|| (expectedLevel != indentInComment && isWarnComment);'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[224,36]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean 'return (containsActualLevel && !isWarnComment)'?
[WARNING] /src/it/java/com/google/checkstyle/test/base/AbstractIndentationTestSupport.java:[225,41]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean '|| (!containsActualLevel && isWarnComment);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBeanTest.java:[348,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getRegisterCount() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/AbstractGuiTestSupport.java:[63,46]
[TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type
is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts
at invocations of the method, and it interacts badly with method overload resolution.
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java:[652,23]
[VoidUsed] Using a Void-typed variable is potentially confusing, and can be replaced with a literal `null`.
(see https://errorprone.info/bugpattern/VoidUsed)
Did you mean '.that(null)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java:[273,25]
[TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type
is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts
at invocations of the method, and it interacts badly with method overload resolution.
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java:[296,25]
[TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type
is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts
at invocations of the method, and it interacts badly with method overload resolution.
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java:[343,25]
[TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type
is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts
at invocations of the method, and it interacts badly with method overload resolution.
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java:[362,25]
[TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type
is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts
at invocations of the method, and it interacts badly with method overload resolution.
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
[WARNING] java/com/puppycrawl/tools/checkstyle/IndentationTrailingCommentsVerticalAlignmentTest.java:
[126,35]
[StreamResourceLeak] Streams that encapsulate a closeable resource should be closed
using try-with-resources
(see https://errorprone.info/bugpattern/StreamResourceLeak)
[INFO] /src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java:[533,5]
[LexicographicalAnnotationAttributeListing] Where possible,
sort annotation array attributes lexicographically
(see https://error-prone.picnic.tech/bugpatterns/LexicographicalAnnotationAttributeListing)
Did you mean '@ValueSource(strings = {"First;Second", "Same;Same"})'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java:[537,52]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final List<String> messages = Splitter.on(';').splitToList(rawMessages);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/XpathFileGeneratorAuditListenerTest.java:[334,43]
[DefaultCharset] Implicit use of the platform default charset, which can result in differing
behaviour between JVM executions or incorrect behavior if the encoding of the
data source doesn't match expectations.
(see https://errorprone.info/bugpattern/DefaultCharset)
Did you mean 'final String actual = out.toString(UTF_8);'
or 'final String actual = out.toString(Charset.defaultCharset());'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTaskTest.java:[637,58]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final String expectedPathEnd = Iterables.get(Splitter.on("**").split(line), 1);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java:[665,21]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean '} while ((lineNo < lines.size()'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/
AvoidEscapedUnicodeCharactersCheckTest.java:[533,58]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final List<String> expressionParts = Splitter.on('|').splitToList(expression);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java:[629,13]
[OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit
(see https://errorprone.info/bugpattern/OperatorPrecedence)
Did you mean '|| (XmlUtil.getNameAttributeOfNode(expected)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[207,23]
[TruthAssertExpected] The actual and expected values appear to be swapped, which results
in poor assertion failure messages. The actual value should come first.
(see https://errorprone.info/bugpattern/TruthAssertExpected)
Did you mean '.that(linesWithWarn.length)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4149,25]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'String[] getExpectedMessages() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4174,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getLineNumber() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4178,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getIndent() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4182,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getIndentOffset() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4186,24]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'boolean isExpectedNonStrict() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4190,23]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'String getExpectedWarning() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/
IndentationCheckTest.java:[4194,24]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'boolean isWarning() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/WriteTagCheckTest.java:[202,43]
[DefaultCharset] Implicit use of the platform default charset, which can result
in differing behaviour between JVM executions or incorrect behavior if the encoding
of the data source doesn't match expectations.
(see https://errorprone.info/bugpattern/DefaultCharset)
Did you mean 'final String output = out.toString(UTF_8);'
or 'final String output = out.toString(Charset.defaultCharset());'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/grammar/
GeneratedJavaTokenTypesTest.java:[789,27]
[TruthAssertExpected] The actual and expected values appear to be swapped, which results in poor
assertion failure messages. The actual value should come first.
(see https://errorprone.info/bugpattern/TruthAssertExpected)
Did you mean '.that(lastIndexOfSublist)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/gui/MainFrameTest.java:[109,91]
[EnumOrdinal] You should almost never invoke the Enum.ordinal() method
or depend on the enum values by index.
(see https://errorprone.info/bugpattern/EnumOrdinal)
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/AllChecksTest.java:[263,68]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final List<String> packageTokens = Splitter.on('.').splitToList(moduleName);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/ArchUnitSuperClassTest.java:[140,34]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java:[273,49]
[JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque.
Avoid it unless you're willing to invest a lot of time into benchmarking.
Caveat: LinkedList supports null elements, but ArrayDeque does not.
(see https://errorprone.info/bugpattern/JdkObsolete)
Did you mean 'final List<RevCommit> filteredCommits = new ArrayList<>();'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java:[329,41]
[JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque.
Avoid it unless you're willing to invest a lot of time into benchmarking.
Caveat: LinkedList supports null elements, but ArrayDeque does not.
(see https://errorprone.info/bugpattern/JdkObsolete)
Did you mean 'final List<RevCommit> commits = new ArrayList<>();'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java:[395,36]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'Iterator<RevCommit> getFirst() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java:[399,36]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'Iterator<RevCommit> getSecond() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[89,26]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[110,26]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[124,26]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[176,22]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[211,22]
[InlineFormatString] Prefer to create format strings inline,
instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[478,23]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'String href() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsCategoryIndexTest.java:[487,23]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'String description() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsJavaDocsTest.java:[141,64]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'for (String temp : Splitter.on('\n').split(child.getTextContent())) {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsJavaDocsTest.java:[347,17]
[StatementSwitchToExpressionSwitch] This statement switch can be converted to a new-style arrow switch
(see https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch)
Did you mean 'switch (parentNode.getType()) {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsPagesTest.java:[104,33]
[InlineFormatString] Prefer to create format strings inline, instead of extracting them to a single-use constant
(see https://errorprone.info/bugpattern/InlineFormatString)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsPagesTest.java:[1247,24]
[OptionalOrElseGet] Prefer `Optional#orElseGet`
over `Optional#orElse` if the fallback requires additional computation
Did you mean '.orElseGet(fieldClass::getSimpleName);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsUrlTest.java:[168,53]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final List<String> moduleAndCheckName ='?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/XpathRegressionTest.java:[127,64]
[StringSplitter] String.split(String) has surprising behavior
(see https://errorprone.info/bugpattern/StringSplitter)
Did you mean 'final List<String> packageTokens = Splitter.on('.').splitToList(moduleName);'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/CheckUtil.java:[272,24]
[ReferenceEquality] Comparison using reference equality instead of value equality
(see https://errorprone.info/bugpattern/ReferenceEquality)
Did you mean 'if (Objects.equals(locale, Locale.ENGLISH)) {' or 'if (locale.equals(Locale.ENGLISH)) {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/BlockCommentPositionTest.java:[144,23]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'String getFileName() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/BlockCommentPositionTest.java:[151,45]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'Function<DetailAST, Boolean> getAssertion() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/BlockCommentPositionTest.java:[158,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getMatchesNum() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/ModuleReflectionUtilTest.java:[226,30]
[UnusedMethod] Method 'method' is never used.
(see https://errorprone.info/bugpattern/UnusedMethod)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/ModuleReflectionUtilTest.java:[226,30]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'abstract void method();'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/ModuleReflectionUtilTest.java:[381,19]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'InvalidNonDefaultConstructorClass(int data) {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/ModuleReflectionUtilTest.java:[392,27]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'final void method(int data) {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/utils/ModuleReflectionUtilTest.java:[396,20]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'int getField() {'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/xpath/XpathQueryGeneratorTest.java:[611,27]
[TruthAssertExpected] The actual and expected values appear to be swapped,
which results in poor assertion failure messages. The actual value should come first.
(see https://errorprone.info/bugpattern/TruthAssertExpected)
Did you mean '.that(actual)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/xpath/XpathQueryGeneratorTest.java:[638,27]
[TruthAssertExpected] The actual and expected values appear to be swapped,
which results in poor assertion failure messages. The actual value should come first.
(see https://errorprone.info/bugpattern/TruthAssertExpected)
Did you mean '.that(actual)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/xpath/XpathQueryGeneratorTest.java:[666,27]
[TruthAssertExpected] The actual and expected values appear to be swapped,
which results in poor assertion failure messages. The actual value should come first.
(see https://errorprone.info/bugpattern/TruthAssertExpected)
Did you mean '.that(actual)'?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/xpath/iterators/ReverseListIteratorTest.java:[70,19]
[UnusedMethod] Constructor 'TestNode' is never used.
(see https://errorprone.info/bugpattern/UnusedMethod)
Did you mean to remove this line?
[WARNING] /src/test/java/com/puppycrawl/tools/checkstyle/xpath/iterators/ReverseListIteratorTest.java:[70,19]
[EffectivelyPrivate] This declaration has public or protected modifiers, but is effectively private.
(see https://errorprone.info/bugpattern/EffectivelyPrivate)
Did you mean 'TestNode(TreeInfo treeInfo) {'?
Error prone WARNING violations to resolve:
./mvnw -e --no-transfer-progress clean test-compile -Perror-prone-test-compileAs soon as all violation of special type are resolved , mark them as ERROR in pom.xml to avoid happening again.