Skip to content

Upgrade all scripts to groovy 3.0.17 or 5.x #17269

@romani

Description

@romani

Detected at https://github.com/checkstyle/checkstyle/pull/17267/files

Run groovy ./.ci/error-prone-check.groovy test-compile
Caught: java.lang.VerifyError: (class: java_util_Set$of, method: callStatic signature: (Ljava/lang/Class;[Ljava/lang/Object;)Ljava/lang/Object;) Illegal type in constant pool
java.lang.VerifyError: (class: java_util_Set$of, method: callStatic signature: (Ljava/lang/Class;[Ljava/lang/Object;)Ljava/lang/Object;) Illegal type in constant pool
	at error-prone-check.<clinit>(error-prone-check.groovy:9)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

https://github.com/checkstyle/checkstyle/blob/5999226299cedb2bd3926b1fd648792ca86e28d7/.ci/error-prone-check.groovy#L9C33-L9C41

We need to upgrade scripts to newest groovy, groovy 4 is also fine
Groovy 5 is not released yet https://groovy.apache.org/download.html
https://groovy.apache.org/download.html , groovy 5 is out !!! lets use it !!!

Extra installation of groovy from that PR should be reverted .github/workflows/error-prone.yml

We need to migrate all groovy scripts in our organization, there are few, not a lot.

Contribution repo migration: checkstyle/contribution#957

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions