You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
problem is that property was added in 8.3 version but check was added to 8.24.
Before when PropertyMacros calculate since value it should compare it with version of Module and if version of module is above then use it.
detected at https://github.com/checkstyle/checkstyle/pull/14049/files#r1398641110
goal is to remove this:
https://github.com/checkstyle/checkstyle/pull/14049/files#diff-582038065de9c242c07931401cfa262fcfd745638bf7c42736dba5793a3294cdR209-R211
and may be whole SINCE_VERSION_FOR_INHERITED_PROPERTY or heavily make it smaller.
HeaderCheck Should have version 3.0 .
as it existed from 2002 - https://github.com/checkstyle/checkstyle/commits/aca96ae1b180a8036cc23e93840c4161ae8f8927/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java?browsing_rename_history=true&new_path=src/main/java/com/puppycrawl/tools/checkstyle/checks/header/HeaderCheck.java&original_branch=master
problem is that property was added in 8.3 version but check was added to 8.24.
Before when PropertyMacros calculate since value it should compare it with version of Module and if version of module is above then use it.
We can try to reuse https://stackoverflow.com/a/65077344/1015848 class to compare versions.
Versions from abstract classes should be used with caution #14048 (comment)