Skip to content

Remove CheckstyleAntTask's classpath parameter #12338

@rnveach

Description

@rnveach

Identified at #12335 (comment) ,

This is left over when we had checks against the classpath. Code was removed at
145160f#diff-56ee8828e56742120dd2db0061ea82707b7b27c5c0f9e9963a8cefe3aa2dbc3aL405
as part of #3773

This is a custom property sent to our Checkstyle Ant. It is not related to Java's classpath loader.

Java's classpath loader is at

<taskdef name="checkstyle"
classname="com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask"
classpath="${mvn.runtime_classpath}"
.

If you examine the code, you will see this property is only used to display as an error if an exception occurs.

throw new BuildException(String.format(Locale.ROOT, "Unable to create Root Module: "
+ "config {%s}, classpath {%s}.", config, classpath), ex);

CI is still running and passing with it removed.

We should deprecate it unless we want to full remove it in one go.

=====

Migration Notes

Gradle users will need to remove any assignments of the classpath as it will no longer exist.
Example: pgjdbc/pgjdbc@327e625

Ant users will need to remove classpath from inside the Checkstyle task as it will not be available anymore.
See sevntu-checkstyle/checkstyle-samples@e424278

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions