Refactor/Update Dockerfile #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxr463
approved these changes
May 25, 2021
Contributor
Author
|
Hi @mrtazz, do you have a minute to take a look? Thanks. |
Collaborator
|
change looks good to me. But it seems there is a conflict with the Dockerfile in the default branch |
Contributor
Author
|
Cool, looks like there are multiple conflicts as the code base changed in the past year, I'll resolve them. |
Contributor
Author
|
Well... it's strange that I can't build the image any more, looks like something is broken during the past year... |
5 tasks
Contributor
Author
|
#51 sent to fix the build first, looks like it's a little bit messy there 😅 |
4b0438f to
b4e3896
Compare
Contributor
Author
|
@mrtazz conflicts resolved! Thanks. |
Contributor
Author
|
@mrtazz any chance to take a look? Thanks. |
Collaborator
|
Thanks for taking the time to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few adjustments to make the Docker image even better 🎉